You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org> on 2023/05/23 13:16:24 UTC

[GitHub] [mynewt-nimble] andrzej-kaczmarek opened a new pull request, #1505: nimble/ll: Fix encryption start procedure

andrzej-kaczmarek opened a new pull request, #1505:
URL: https://github.com/apache/mynewt-nimble/pull/1505

   We need to update rx packet counter and direction bit after sending LL_START_ENC_RSP in central role as otherwise we will fail to decrypt LL_START_ENC_RSP from peripheral and will drop connection due to MIC failure.
   
   This only happens if peripheral replies with LL_START_ENC_RSP in the next slot after we send LL_START_ENC_RSP. If peripheral replies with an empty PDU instead, we will update direction bit on continuation and decryption on rx will be successful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1505: nimble/ll: Fix encryption start procedure

Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1505:
URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559460084

   AutoPTS Bot results:
   No failed test found.
   <details><summary>Successful tests</summary>SM      SM/CEN/JW/BI-04-C               PASS</details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] mkasenberg commented on pull request #1505: nimble/ll: Fix encryption start procedure

Posted by "mkasenberg (via GitHub)" <gi...@apache.org>.
mkasenberg commented on PR #1505:
URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559436705

   #AutoPTS run mynewt SM/CEN/JW/BI-04-C


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] andrzej-kaczmarek merged pull request #1505: nimble/ll: Fix encryption start procedure

Posted by "andrzej-kaczmarek (via GitHub)" <gi...@apache.org>.
andrzej-kaczmarek merged PR #1505:
URL: https://github.com/apache/mynewt-nimble/pull/1505


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [mynewt-nimble] codecoup-tester commented on pull request #1505: nimble/ll: Fix encryption start procedure

Posted by "codecoup-tester (via GitHub)" <gi...@apache.org>.
codecoup-tester commented on PR #1505:
URL: https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559444680

   Scheduled PR #https://github.com/apache/mynewt-nimble/pull/1505#issuecomment-1559436705 after 16:00:26.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org