You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by bharat kumar <bh...@citrix.com> on 2013/05/06 18:42:12 UTC
Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10948/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Description
-------
Cloudstack-702. Multiple ip ranges in different subnets.
This feature enables adding of guest ip ranges (public ips) form different subnets.
In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router.
The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias.
I have pushed the code to github https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9 , also rebased the code with master.
I need to test the code for advanced sg enabled network using kvm.
The code dose not include any unit tests as of now. will add them asap.
This addresses bug Cloudstack-702.
https://issues.apache.org/jira/browse/Cloudstack-702
Diffs
-----
Diff: https://reviews.apache.org/r/10948/diff/
Testing
-------
Tested this with xenserver in basic zone.
Thanks,
bharat kumar
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10948/#review20313
-----------------------------------------------------------
Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/marvin_refactor from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]
CLOUDSTACK-702: Tests for Multiple IP Ranges-R4
Add ip range overlapped with two ip ranges in the exiting cidr
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 6, 2013, 4:42 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10948/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 4:42 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-702. Multiple ip ranges in different subnets.
>
> This feature enables adding of guest ip ranges (public ips) form different subnets.
>
> In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router.
>
> The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias.
>
> I have pushed the code to github https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9 , also rebased the code with master.
> I need to test the code for advanced sg enabled network using kvm.
>
> The code dose not include any unit tests as of now. will add them asap.
>
>
> This addresses bug Cloudstack-702.
> https://issues.apache.org/jira/browse/Cloudstack-702
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/10948/diff/
>
>
> Testing
> -------
>
> Tested this with xenserver in basic zone.
>
>
> Thanks,
>
> bharat kumar
>
>
Re: Review Request: Cloudstack-702 Multiple Ip ranges in different subnets
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10948/#review20307
-----------------------------------------------------------
Commit 53e496517ed51bab2c81084a02f49b0408b19a37 in branch refs/heads/master from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=53e4965 ]
CLOUDSTACK-702: Tests for Multiple IP Ranges-R4
Add ip range overlapped with two ip ranges in the exiting cidr
Signed-off-by: sanjeevneelarapu <sa...@citrix.com>
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 6, 2013, 4:42 p.m., bharat kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10948/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 4:42 p.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Description
> -------
>
> Cloudstack-702. Multiple ip ranges in different subnets.
>
> This feature enables adding of guest ip ranges (public ips) form different subnets.
>
> In order to provide the dhcp service to a different subnet we create an ipalias on the router. This allows the router to listen to the dhcp request from the guest vms and respond accordingly. Every time a vm is deployed in the new subnet we configure an ip alias on the router. Cloudstack uses dnsmasq to provide dhcp service. We need to configure the dnsmasq to issue ips on the new subnets. Added a new class dnsmasqconfigurator which generates the dnsmasq confg file, this file replaces the old config in the router.
>
> The details of the alias ips are stored in db in the nic_ip_alias table. Every time a new subnet is added one of the ip from the subnet is used to configure the ip alias.
>
> I have pushed the code to github https://github.com/bvbharatk/cloud-stack/commit/052ebe7fc7dea5ece99cadc23b306c5f8d6e0ea9 , also rebased the code with master.
> I need to test the code for advanced sg enabled network using kvm.
>
> The code dose not include any unit tests as of now. will add them asap.
>
>
> This addresses bug Cloudstack-702.
> https://issues.apache.org/jira/browse/Cloudstack-702
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/10948/diff/
>
>
> Testing
> -------
>
> Tested this with xenserver in basic zone.
>
>
> Thanks,
>
> bharat kumar
>
>