[GitHub] [solr] dweiss commented on a change in pull request #501: Dynamically discover lucene version for use in build

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #501:
URL: https://github.com/apache/solr/pull/501#discussion_r782747529



##########
File path: gradle/lucene-dev/lucene-dev-repo-composite.gradle
##########
@@ -130,6 +130,21 @@ if (luceneDevRepo != null) {
   } else {
     // We're being applied at build-time and Lucene development repository exists. Configure
     // certain aspects of the build so that things work with it.
+    
+    // replace luceneBaseVersionProvider by one evaluating the included build:
+    configure(rootProject) {
+      def line = new File(gradle.includedBuild('lucene').projectDir, 'build.gradle').readLines("UTF-8").find { it =~ /\bbaseVersion\s*=\s*['"]/ }

Review comment:
       Yep. included builds don't really have a notion of "version" - they only have coordinates (they're treated much like subprojects). I don't know if there is a better solution than that presented here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org