[GitHub] [airflow] deedmitrij commented on a change in pull request #19014: Fix Cloud SQL system tests

[GitBox <gi...@apache.org>]

deedmitrij commented on a change in pull request #19014:
URL: https://github.com/apache/airflow/pull/19014#discussion_r742935551



##########
File path: tests/providers/google/cloud/operators/test_cloud_sql_system.py
##########
@@ -34,27 +35,98 @@
 from tests.test_utils.gcp_system_helpers import CLOUD_DAG_FOLDER, GoogleSystemTest, provide_gcp_context
 
 GCP_PROJECT_ID = os.environ.get('GCP_PROJECT_ID', 'project-id')
+CLOUD_SQL_BUCKET_NAME = os.environ.get('CLOUD_SQL_BUCKET_NAME', 'INVALID BUCKET NAME')
 
 SQL_QUERY_TEST_HELPER = CloudSqlQueryTestHelper()
 
 
+@pytest.fixture(scope='class')
+def env_patch():
+    """
+    A convenient fixture for environment variables patching.
+    All modifications will be undone after the requesting test class has finished.
+    """
+    from _pytest.monkeypatch import MonkeyPatch
+    mpatch = MonkeyPatch()

Review comment:
       But it's important change to have the working test. Currently, we are working on new automation process, so anyway we will have inconsistent tests with the rest. But we need to have this working test for now at first, so, please, pay attention again to this changes and I'll appreciate if you merge them.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org