You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Michael Park <mp...@apache.org> on 2016/01/27 01:15:50 UTC

Review Request 42834: Added more getters to the `Sorter`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42834/
-----------------------------------------------------------

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
-------

This patch adds the following getters:
  - `total` (similar to `allocation`)
  - `allocationScalars`
  - `totalScalars`

The scalar versions are necessary to improve perf of the allocator.


Diffs
-----

  src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
  src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824 
  src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 

Diff: https://reviews.apache.org/r/42834/diff/


Testing
-------


Thanks,

Michael Park

Re: Review Request 42834: Added more getters to the `Sorter`.

Posted by Joris Van Remoortere <jo...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42834/#review116490
-----------------------------------------------------------


Ship it!




- Joris Van Remoortere


On Jan. 27, 2016, 12:15 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42834/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 12:15 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds the following getters:
>   - `total` (similar to `allocation`)
>   - `allocationScalars`
>   - `totalScalars`
> 
> The scalar versions are necessary to improve perf of the allocator.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/sorter/drf/sorter.hpp 050896e8b12cd4097ccd137d5284d6b39b0f06ab 
>   src/master/allocator/sorter/drf/sorter.cpp 3a442f121f3a1505513877a5c78458a4b8d0a824 
>   src/master/allocator/sorter/sorter.hpp 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 
> 
> Diff: https://reviews.apache.org/r/42834/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>