[GitHub] [ozone] tanvipenumudy commented on a diff in pull request #3427: HDDS-6765. Get snapshot of write OMLockMetrics

[GitBox <gi...@apache.org>]

tanvipenumudy commented on code in PR #3427:
URL: https://github.com/apache/ozone/pull/3427#discussion_r879270722


##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/lock/OMLockMetrics.java:
##########
@@ -203,5 +203,7 @@ public void getMetrics(MetricsCollector collector, boolean all) {
     MetricsRecordBuilder builder = collector.addRecord(SOURCE_NAME);
     readLockHeldTimeMsStat.snapshot(builder, all);
     readLockWaitingTimeMsStat.snapshot(builder, all);
+    writeLockHeldTimeMsStat.snapshot(builder, all);
+    writeLockWaitingTimeMsStat.snapshot(builder, all);

Review Comment:
   Thank you for the suggestion! I have added a test case for this patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org