You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/23 13:53:28 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #3168: Faster ByteArray to StringArray conversion
tustvold opened a new pull request, #3168:
URL: https://github.com/apache/arrow-rs/pull/3168
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3168: Faster BinaryArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#discussion_r1031244881
##########
arrow-array/src/array/string_array.rs:
##########
@@ -216,8 +216,19 @@ impl<OffsetSize: OffsetSizeTrait> From<GenericBinaryArray<OffsetSize>>
for GenericStringArray<OffsetSize>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
+ let offsets = v.value_offsets();
+ let values = v.data().buffers()[1].as_ref();
+
+ // We only need to validate that all values are valid UTF-8
+ let validated = std::str::from_utf8(values).unwrap();
+ for offset in offsets.iter() {
+ assert!(validated.is_char_boundary(offset.as_usize()))
+ }
+
let builder = v.into_data().into_builder().data_type(Self::DATA_TYPE);
- Self::from(builder.build().unwrap())
+ // SAFETY:
+ // Validated UTF-8 above
Review Comment:
```
byte_array_to_string_array 20000
time: [13.252 µs 13.254 µs 13.257 µs]
change: [-67.094% -67.073% -67.049%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) high mild
6 (6.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3168: Faster BinaryArray to StringArray conversion (~67%)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#issuecomment-1326207945
Benchmark runs are scheduled for baseline = 1d22fe3c23cc6ea1fb1df560c35f73cfdad96612 and contender = 8ba78427ef2fea52ffabe91104b74b17906b3772. 8ba78427ef2fea52ffabe91104b74b17906b3772 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/62d7285bf9164f8f80c47fd0c48ae060...673eaaf9d2e44b31b11ba6c9568cf088/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/a32ce55df9144bca94ee6f232f8c15b2...0664d06ee1394c4698fe72c112fbc0aa/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2f17788612bf4f96848015810f631cb2...74ae93c0764043d7a6397904e8949a6f/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/145a7f312fc642918846b438dc4bfebb...a2d0aae4162a469e82e4c308525863d6/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3168: Faster BinaryArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] HaoYang670 commented on a diff in pull request #3168: Faster ByteArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
HaoYang670 commented on code in PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#discussion_r1030986250
##########
arrow-array/src/array/string_array.rs:
##########
@@ -216,8 +216,19 @@ impl<OffsetSize: OffsetSizeTrait> From<GenericBinaryArray<OffsetSize>>
for GenericStringArray<OffsetSize>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
+ let offsets = v.value_offsets();
+ let values = v.data().buffers()[1].as_ref();
+
+ // We only need to validate that all values are valid UTF-8
+ let validated = std::str::from_utf8(values).unwrap();
+ for offset in offsets.iter() {
+ assert!(validated.is_char_boundary(offset.as_usize()))
+ }
+
let builder = v.into_data().into_builder().data_type(Self::DATA_TYPE);
- Self::from(builder.build().unwrap())
+ // SAFETY:
+ // Validated UTF-8 above
Review Comment:
👍
How much performance improvement can we get?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3168: Faster BinaryArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#discussion_r1031219646
##########
arrow-array/src/array/string_array.rs:
##########
@@ -216,8 +216,19 @@ impl<OffsetSize: OffsetSizeTrait> From<GenericBinaryArray<OffsetSize>>
for GenericStringArray<OffsetSize>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
+ let offsets = v.value_offsets();
+ let values = v.data().buffers()[1].as_ref();
+
+ // We only need to validate that all values are valid UTF-8
+ let validated = std::str::from_utf8(values).unwrap();
+ for offset in offsets.iter() {
+ assert!(validated.is_char_boundary(offset.as_usize()))
+ }
+
let builder = v.into_data().into_builder().data_type(Self::DATA_TYPE);
- Self::from(builder.build().unwrap())
Review Comment:
Does it basically remove full validation cost?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #3168: Faster BinaryArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
viirya commented on code in PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#discussion_r1031226291
##########
arrow-array/src/array/string_array.rs:
##########
@@ -216,8 +216,19 @@ impl<OffsetSize: OffsetSizeTrait> From<GenericBinaryArray<OffsetSize>>
for GenericStringArray<OffsetSize>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
+ let offsets = v.value_offsets();
+ let values = v.data().buffers()[1].as_ref();
+
+ // We only need to validate that all values are valid UTF-8
+ let validated = std::str::from_utf8(values).unwrap();
+ for offset in offsets.iter() {
+ assert!(validated.is_char_boundary(offset.as_usize()))
+ }
Review Comment:
Do we need to exclude last offset?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3168: Faster BinaryArray to StringArray conversion
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3168:
URL: https://github.com/apache/arrow-rs/pull/3168#discussion_r1031228271
##########
arrow-array/src/array/string_array.rs:
##########
@@ -216,8 +216,19 @@ impl<OffsetSize: OffsetSizeTrait> From<GenericBinaryArray<OffsetSize>>
for GenericStringArray<OffsetSize>
{
fn from(v: GenericBinaryArray<OffsetSize>) -> Self {
+ let offsets = v.value_offsets();
+ let values = v.data().buffers()[1].as_ref();
+
+ // We only need to validate that all values are valid UTF-8
+ let validated = std::str::from_utf8(values).unwrap();
+ for offset in offsets.iter() {
+ assert!(validated.is_char_boundary(offset.as_usize()))
+ }
Review Comment:
No, in case the string is sliced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org