[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #1050: bugfix: GetAllConsumerIds with no version filter

[GitBox <gi...@apache.org>]

robotLJW opened a new pull request #1050:
URL: https://github.com/apache/servicecomb-service-center/pull/1050


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
    - [ ] Never comment source code, delete it.
    - [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] tianxiaoliang commented on pull request #1050: bugfix: GetAllConsumerIds with no version filter

[GitBox <gi...@apache.org>]

tianxiaoliang commented on pull request #1050:
URL: https://github.com/apache/servicecomb-service-center/pull/1050#issuecomment-861940811


   使用bug report模板记录bug


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-service-center] fuziye01 commented on a change in pull request #1050: bugfix: GetAllConsumerIds with no version filter

[GitBox <gi...@apache.org>]

fuziye01 commented on a change in pull request #1050:
URL: https://github.com/apache/servicecomb-service-center/pull/1050#discussion_r652301150



##########
File path: datasource/mongo/event/instance_event_handler.go
##########
@@ -157,3 +166,170 @@ func NotifySyncerInstanceEvent(event sd.MongoEvent, microService *discovery.Micr
 
 	log.Debug(fmt.Sprintf("success to add instance change event action [%s], instanceKey : %s to event queue", instEvent.Action, instanceKey))
 }
+
+func getAllConsumerIDs(ctx context.Context, provider *discovery.MicroService) (allow []string, deny []string, err error) {
+	if provider == nil || len(provider.ServiceId) == 0 {
+		return nil, nil, fmt.Errorf("invalid provider")
+	}
+
+	//todo 删除服务，最后实例推送有误差
+	providerRules, ok := cache.GetRulesByServiceID(provider.ServiceId)

Review comment:
       缓存的版本过滤也应该做




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org