[jira] [Commented] (SCB-239) [pack] omega recovery

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16350478#comment-16350478 ] 

ASF GitHub Bot commented on SCB-239:
------------------------------------

seanyinx commented on a change in pull request #122: SCB-239 omega stateless
URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165661954
 
 

 ##########
 File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java
 ##########
 @@ -40,11 +51,33 @@ public boolean handle(TxEvent event) {
       return false;
     }
 
+    if (isEventWithTimeout(event)) {
+      saveTxTimeout(event);
+    }
+
     eventRepository.save(event);
 
+    if (Arrays.asList(TxEndedEvent.name(), SagaEndedEvent.name(), TxAbortedEvent.name()).contains(event.type())) {
+      CompletableFuture.runAsync(() -> timeoutRepository.markTxTimeoutAsDone(event.globalTxId(), event.localTxId()));
 
 Review comment:
   this makes alpha stateful, which we try to avoid

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> [pack] omega recovery
> ---------------------
>
>                 Key: SCB-239
>                 URL: https://issues.apache.org/jira/browse/SCB-239
>             Project: Apache ServiceComb
>          Issue Type: Improvement
>          Components: Saga
>    Affects Versions: saga-0.1.0
>            Reporter: Eric Lee
>            Assignee: Eric Lee
>            Priority: Major
>             Fix For: saga-0.1.0
>
>
> as a user, I want to have the pending data stored persistently and be able to resume the execution of these data if omega fails.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)