You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by pk...@apache.org on 2022/03/28 22:10:17 UTC

[logging-log4j2] 02/07: Don't be verbose by specifying the default value for a boolean.

This is an automated email from the ASF dual-hosted git repository.

pkarwasz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/logging-log4j2.git

commit d97976ff4e8753247480dc7c77891af302977842
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Fri Feb 4 16:17:31 2022 -0500

    Don't be verbose by specifying the default value for a boolean.
---
 .../java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java | 2 +-
 .../main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
index 889a4c8..dba015e 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/appender/ConsoleAppenderBuilder.java
@@ -155,7 +155,7 @@ public class ConsoleAppenderBuilder extends AbstractBuilder implements AppenderB
         Filter filter = configuration.parseAppenderFilters(props, filterPrefix, name);
         String level = getProperty(THRESHOLD_PARAM);
         String target = getProperty(TARGET_PARAM);
-        boolean follow = getBooleanProperty(FOLLOW_PARAM, false);
+        boolean follow = getBooleanProperty(FOLLOW_PARAM);
         return createAppender(name, layout, filter, level, target, follow, configuration);
     }
 
diff --git a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java
index c800ed4..860b339 100644
--- a/log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java
+++ b/log4j-1.2-api/src/main/java/org/apache/log4j/builders/layout/HtmlLayoutBuilder.java
@@ -70,7 +70,7 @@ public class HtmlLayoutBuilder extends AbstractBuilder implements LayoutBuilder
     @Override
     public Layout parseLayout(PropertiesConfiguration config) {
         String title = getProperty(TITLE_PARAM, DEFAULT_TITLE);
-        boolean locationInfo = getBooleanProperty(LOCATION_INFO_PARAM, false);
+        boolean locationInfo = getBooleanProperty(LOCATION_INFO_PARAM);
         return createLayout(title, locationInfo);
     }