[GitHub] [skywalking] mrproliu commented on a diff in pull request #9377: Add eBPF Network Profiling E2E

[GitBox <gi...@apache.org>]

mrproliu commented on code in PR #9377:
URL: https://github.com/apache/skywalking/pull/9377#discussion_r928460336


##########
oap-server/analyzer/meter-analyzer/src/main/java/org/apache/skywalking/oap/meter/analyzer/k8s/K8sInfoRegistry.java:
##########
@@ -234,17 +236,17 @@ private void recompose() {
             });
         });
         nameServiceMap.forEach((serviceName, service) -> {
-            if (isNull(service.getMetadata()) || isNull(service.getStatus()) || isNull(service.getStatus().getLoadBalancer())) {
-                return;
-            }
-            final List<V1LoadBalancerIngress> ingress = service.getStatus().getLoadBalancer().getIngress();
-            if (CollectionUtils.isEmpty(ingress)) {
-                return;
+            if (!isNull(service.getSpec()) && CollectionUtils.isNotEmpty(service.getSpec().getClusterIPs())) {

Review Comment:
   @sonatype-lift ignore



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org