[GitHub] [drill] cgivre commented on a change in pull request #2310: DRILL-7993: LGTM Code Cleanup-Fixed Javadoc param tags and type conversions

[GitBox <gi...@apache.org>]

cgivre commented on a change in pull request #2310:
URL: https://github.com/apache/drill/pull/2310#discussion_r706736241



##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/VarLenOverflowReader.java
##########
@@ -39,8 +39,8 @@
   /**
    * CTOR.
    * @param buffer byte buffer for data buffering (within CPU cache)
-   * @param pageInfo page being processed information
-   * @param columnPrecInfo column precision information
+   * @param containerCallback

Review comment:
       I think we need some descriptor here as well.  As I'm not familiar with the code, perhaps just something obvious like 
   `callbackContainer The call back container`.  Not particularly helpful, but at least there is something. 

##########
File path: drill-yarn/src/main/java/org/apache/drill/yarn/appMaster/DrillControllerFactory.java
##########
@@ -185,7 +185,7 @@ public Dispatcher build() throws ControllerFactoryException {
    * This class is very Linux-specific. The usual adjustments must be made to
    * adapt it to Windows.
    *
-   * @param config
+   * @param resources
    * @return
    * @throws DoyConfigException
    */

Review comment:
       Perhaps `Map of local resource configurations`?

##########
File path: exec/java-exec/src/main/java/org/apache/drill/exec/util/record/RecordBatchStats.java
##########
@@ -49,7 +49,8 @@
     private final String contextOperatorId;
 
     /**
-     * @param options options manager
+     * @param context
+     * @param oContext

Review comment:
       Here as well... 

##########
File path: logical/src/main/java/org/apache/drill/common/graph/GraphAlgos.java
##########
@@ -69,8 +69,7 @@ private void visit(AdjacencyList<V>.Node n) {
      *
      * @param graph
      *          The adjacency list for the DAG.
-     * @param sourceNodes
-     *          List of nodes that
+     * @param reverse

Review comment:
       And finally here. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org