You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/04 21:08:25 UTC
[GitHub] [airflow] potiuk opened a new pull request #17424: Fix failing static checks in main
potiuk opened a new pull request #17424:
URL: https://github.com/apache/airflow/pull/17424
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#discussion_r682970446
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
Right. The If above is only for K8S executor. I always associated LocalExecutor with running everything on one machine and reading logs from filesystem, but indeed webserver might run separately. I am not sure though if Log server actually runs for Scheduler in this case ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#issuecomment-892977748
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17424:
URL: https://github.com/apache/airflow/pull/17424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#discussion_r682973454
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
Ah yeah. It runs actually for both Sequential and Local Executor :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#issuecomment-892977748
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#discussion_r682970446
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
Right. The If above is only for K8S executor. I always associated LocalExecutor with running everything on one machine and reading logs from filesystem, but indeed webserver might run separately. I am not sure though if Log server actually runs for Scheduler in this case ?
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
Ah yeah. It runs actually for both Sequential and Local Executor :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17424:
URL: https://github.com/apache/airflow/pull/17424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#discussion_r682964300
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
```suggestion
"*** !!!! Please make sure that all your Airflow components (e.g. schedulers, webservers and workers) have"
```
Could also be the scheduler when using a local executor 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on a change in pull request #17424: Fix failing static checks in main
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on a change in pull request #17424:
URL: https://github.com/apache/airflow/pull/17424#discussion_r682964300
##########
File path: airflow/utils/log/file_task_handler.py
##########
@@ -187,10 +187,14 @@ def _read(self, ti, try_number, metadata=None):
response.encoding = "utf-8"
if response.status_code == 403:
- log += "*** !!!! Please make sure that all your webservers and workers have" \
- " the same 'secret_key' configured in 'webserver' section !!!!!\n***"
- log += "*** See more at https://airflow.apache.org/docs/apache-airflow/" \
- "stable/configurations-ref.html#secret-key\n***"
+ log += (
+ "*** !!!! Please make sure that all your webservers and workers have"
Review comment:
```suggestion
"*** !!!! Please make sure that all your Airflow components (e.g. schedulers, webservers and workers) have"
```
Could also be the scheduler when using a local executor 🤷♂️
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org