You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/08/10 08:51:52 UTC
[GitHub] [helix] kaisun2000 opened a new issue #1241: Fix thread leakage in TestClusterSetup
kaisun2000 opened a new issue #1241:
URL: https://github.com/apache/helix/issues/1241
Two issues:
- The log shows TestClusterSetup leaks around 15 ZkClients. This need to be fixed.
>END testDisableResource at Mon Aug 10 01:35:19 PDT 2020, took: 123ms.
AfterClass: TestClusterSetup of TestClusterSetup called.
END TestClusterSetup.afterClass() Mon Aug 10 01:35:19 PDT 2020
AfterClass:TestClusterSetup afterclass of ZkTestBase called!
TestClusterSetup has active threads cnt:67
zookeeper server threads has 4 thread
Failure zkclient/zooKeeper session threads has 55 thread
0 thread:ZkClient-EventThread-88-localhost:2183
1 thread:ZkClient-EventThread-24-localhost:2183
2 thread:ZkClient-AsyncCallback-Retry-90-localhost:2183
3 thread:ZkClient-AsyncCallback-Retry-135-localhost:2183
4 thread:ZkClient-AsyncCallback-Retry-92-localhost:2183
5 thread:ZkClient-EventThread-119-localhost:2183
6 thread:ZkClient-AsyncCallback-Retry-99-localhost:2183
7 thread:ZkClient-EventThread-20-localhost:2183
8 thread:ZkClient-AsyncCallback-Retry-19-localhost:2183
9 thread:main-EventThread
10 thread:ZkClient-AsyncCallback-Retry-23-localhost:2183
11 thread:ZkClient-AsyncCallback-Retry-118-localhost:2183
12 thread:ZkClient-AsyncCallback-Retry-133-localhost:2183
13 thread:ZkClient-AsyncCallback-Retry-75-localhost:2183
14 thread:ZkClient-EventThread-100-localhost:2183
15 thread:ZkClient-EventThread-132-localhost:2183
16 thread:main-SendThread(localhost:2183)
17 thread:ZkClient-EventThread-121-localhost:2183
18 thread:ZkClient-AsyncCallback-Retry-122-localhost:2183
19 thread:main-SendThread(localhost:2183)
20 thread:ZkClient-AsyncCallback-Retry-105-localhost:2183
21 thread:ZkClient-EventThread-28-localhost:2183
22 thread:ZkClient-AsyncCallback-Retry-85-localhost:2183
23 thread:ZkClient-EventThread-95-localhost:2183
24 thread:ZkClient-EventThread-111-localhost:2183
25 thread:ZkClient-EventThread-91-localhost:2183
26 thread:ZkClient-EventThread-125-localhost:2183
27 thread:ZkClient-EventThread-117-localhost:2183
28 thread:ZkClient-EventThread-76-localhost:2183
29 thread:TestNGInvoker-testDropInstance()-EventThread
30 thread:ZkClient-AsyncCallback-Retry-27-localhost:2183
31 thread:ZkClient-AsyncCallback-Retry-112-localhost:2183
32 thread:ZkClient-AsyncCallback-Retry-101-localhost:2183
33 thread:ZkClient-EventThread-130-localhost:2183
34 thread:ZkClient-EventThread-102-localhost:2183
35 thread:ZkClient-EventThread-86-localhost:2183
36 thread:main-EventThread
37 thread:ZkClient-EventThread-123-localhost:2183
38 thread:ZkClient-EventThread-104-localhost:2183
39 thread:ZkClient-EventThread-93-localhost:2183
40 thread:ZkClient-EventThread-136-localhost:2183
41 thread:main-EventThread
42 thread:ZkClient-EventThread-106-localhost:2183
43 thread:ZkClient-AsyncCallback-Retry-131-localhost:2183
44 thread:ZkClient-EventThread-113-localhost:2183
45 thread:ZkClient-EventThread-134-localhost:2183
46 thread:ZkClient-AsyncCallback-Retry-124-localhost:2183
47 thread:ZkClient-AsyncCallback-Retry-103-localhost:2183
48 thread:ZkClient-AsyncCallback-Retry-94-localhost:2183
49 thread:main-SendThread(localhost:2183)
50 thread:ZkClient-AsyncCallback-Retry-116-localhost:2183
51 thread:ZkClient-AsyncCallback-Retry-87-localhost:2183
52 thread:ZkClient-AsyncCallback-Retry-120-localhost:2183
53 thread:ZkClient-AsyncCallback-Retry-110-localhost:2183
54 thread:ZkClient-AsyncCallback-Retry-129-localhost:2183
Failure Other threads has 4 thread
0 thread:TestNGInvoker-testDropInstance(localhost:2183)
1 thread:main
2 thread:surefire-forkedjvm-command-thread
3 thread:surefire-forkedjvm-ping-30s
---------- Test Class TestClusterSetup thread leakage detected! ---------------
- Note, there is another bug that @afterClass of base class etc won't be called. This issue is tracked in https://github.com/apache/helix/issues/1240
After spending a lot of time testing, I found mvn 3.6.1 with current Testng combination has the following bug.
If some test method in a class use @test(dependsOnMethod="blah"). If other methods without dependsOnMethod attribute will not be run. What is more, @afterclass of this class and all the base class won't run either.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] kaisun2000 commented on issue #1241: Fix thread leakage in TestClusterSetup
Posted by GitBox <gi...@apache.org>.
kaisun2000 commented on issue #1241:
URL: https://github.com/apache/helix/issues/1241#issuecomment-671800639
This is addressed in https://github.com/apache/helix/pull/1227
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org