You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@harmony.apache.org by Nathan Beyer <nd...@apache.org> on 2008/06/03 02:20:55 UTC
Re: svn commit: r662447 - in /harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2: ./ META-INF/ META-INF/MANIFEST.MF
BTW - java.* classes don't need to be imported; however, javax.* package do
On Mon, Jun 2, 2008 at 9:26 AM, <sj...@apache.org> wrote:
> Author: sjanuary
> Date: Mon Jun 2 07:26:26 2008
> New Revision: 662447
>
> URL: http://svn.apache.org/viewvc?rev=662447&view=rev
> Log:
> New manifest file for bcel (to be used by pack200)
>
> Added:
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/
>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> (with props)
>
> Added:
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> URL:
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF?rev=662447&view=auto
>
> ==============================================================================
> ---
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> (added)
> +++
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> Mon Jun 2 07:26:26 2008
> @@ -0,0 +1,17 @@
> +Manifest-Version: 1.0
> +Bundle-ManifestVersion: 2
> +Bundle-Name: BCEL
> +Bundle-SymbolicName: org.apache.bcel;singleton:=true
> +Bundle-Version: 5.2
> +Bundle-ClassPath: bcel-5.2.jar
> +Eclipse-JREBundle: true
> +Import-Package: java.io,
> + java.lang
> +Export-Package: org.apache.bcel,
> + org.apache.bcel.classfile,
> + org.apache.bcel.generic,
> + org.apache.bcel.util,
> + org.apache.bcel.verifier,
> + org.apache.bcel.verifier.exc,
> + org.apache.bcel.verifier.statics,
> + org.apache.bcel.verifier.structurals
>
> Propchange:
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>
> ------------------------------------------------------------------------------
> svn:eol-style = native
>
> Propchange:
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>
> ------------------------------------------------------------------------------
> svn:mime-type = text/plain
>
>
>
Re: svn commit: r662447 - in /harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2: ./ META-INF/ META-INF/MANIFEST.MF
Posted by Nathan Beyer <nb...@gmail.com>.
Perhaps the symbolic name on this one should follow the mx4j name -
org.apache.harmony.management.mx4j. At a minimum, we should probably name it
org.apache.harmony.bcel.
On Tue, Jun 3, 2008 at 5:52 AM, Sian January <si...@googlemail.com>
wrote:
> That's interesting. I've learnt two new things about OSGi today!
>
> It looks like I have added that header anyway as I copied one of the other
> manifests to create the one for bcel, so should all be fine.
>
> Thanks,
>
> Sian
>
> On 03/06/2008, Tim Ellison <t....@gmail.com> wrote:
> >
> > Sian January wrote:
> >
> >> Thanks Nathan - I hadn't realised that because all the other manifests
> >> have
> >> java.* imports. Do you think it would be worth changing them?
> >>
> >
> > Normally you would not have to import java.* packages, because they are
> > part of the Java platform assumed to be present to the OSGi runtime. But,
> of
> > course, we are implementing the java.* packages so we do want to import
> and
> > export them explicitly to get the modularity in the class libraries.
> >
> > The special header
> > Eclipse-JREBundle: true
> > tells Equinox not to import the java.* packages by default, so we see
> > breakages when the import of platform packages is missing.
> >
> > Regards,
> > Tim
> >
> >
> > On 03/06/2008, Nathan Beyer <nd...@apache.org> wrote:
> >>
> >>> BTW - java.* classes don't need to be imported; however, javax.*
> package
> >>> do
> >>>
> >>> On Mon, Jun 2, 2008 at 9:26 AM, <sj...@apache.org> wrote:
> >>>
> >>> Author: sjanuary
> >>>> Date: Mon Jun 2 07:26:26 2008
> >>>> New Revision: 662447
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=662447&view=rev
> >>>> Log:
> >>>> New manifest file for bcel (to be used by pack200)
> >>>>
> >>>> Added:
> >>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/
> >>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/
> >>>>
> >>>>
> >>>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>> (with props)
> >>>>
> >>>> Added:
> >>>>
> >>>>
> >>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>
> >>>> URL:
> >>>>
> >>>>
> >>>
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF?rev=662447&view=auto
> >>>
> >>>>
> >>>>
> >>>
> ==============================================================================
> >>>
> >>>> ---
> >>>>
> >>>>
> >>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>
> >>>> (added)
> >>>> +++
> >>>>
> >>>>
> >>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>
> >>>> Mon Jun 2 07:26:26 2008
> >>>> @@ -0,0 +1,17 @@
> >>>> +Manifest-Version: 1.0
> >>>> +Bundle-ManifestVersion: 2
> >>>> +Bundle-Name: BCEL
> >>>> +Bundle-SymbolicName: org.apache.bcel;singleton:=true
> >>>> +Bundle-Version: 5.2
> >>>> +Bundle-ClassPath: bcel-5.2.jar
> >>>> +Eclipse-JREBundle: true
> >>>> +Import-Package: java.io,
> >>>> + java.lang
> >>>> +Export-Package: org.apache.bcel,
> >>>> + org.apache.bcel.classfile,
> >>>> + org.apache.bcel.generic,
> >>>> + org.apache.bcel.util,
> >>>> + org.apache.bcel.verifier,
> >>>> + org.apache.bcel.verifier.exc,
> >>>> + org.apache.bcel.verifier.statics,
> >>>> + org.apache.bcel.verifier.structurals
> >>>>
> >>>> Propchange:
> >>>>
> >>>>
> >>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>
> >>>>
> >>>>
> >>>
> ------------------------------------------------------------------------------
> >>>
> >>>> svn:eol-style = native
> >>>>
> >>>> Propchange:
> >>>>
> >>>>
> >>>
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >>>
> >>>>
> >>>>
> >>>
> ------------------------------------------------------------------------------
> >>>
> >>>> svn:mime-type = text/plain
> >>>>
> >>>>
> >>>>
> >>>>
> >>
> >>
> >>
>
>
> --
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
>
Re: svn commit: r662447 - in /harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2: ./ META-INF/ META-INF/MANIFEST.MF
Posted by Sian January <si...@googlemail.com>.
That's interesting. I've learnt two new things about OSGi today!
It looks like I have added that header anyway as I copied one of the other
manifests to create the one for bcel, so should all be fine.
Thanks,
Sian
On 03/06/2008, Tim Ellison <t....@gmail.com> wrote:
>
> Sian January wrote:
>
>> Thanks Nathan - I hadn't realised that because all the other manifests
>> have
>> java.* imports. Do you think it would be worth changing them?
>>
>
> Normally you would not have to import java.* packages, because they are
> part of the Java platform assumed to be present to the OSGi runtime. But, of
> course, we are implementing the java.* packages so we do want to import and
> export them explicitly to get the modularity in the class libraries.
>
> The special header
> Eclipse-JREBundle: true
> tells Equinox not to import the java.* packages by default, so we see
> breakages when the import of platform packages is missing.
>
> Regards,
> Tim
>
>
> On 03/06/2008, Nathan Beyer <nd...@apache.org> wrote:
>>
>>> BTW - java.* classes don't need to be imported; however, javax.* package
>>> do
>>>
>>> On Mon, Jun 2, 2008 at 9:26 AM, <sj...@apache.org> wrote:
>>>
>>> Author: sjanuary
>>>> Date: Mon Jun 2 07:26:26 2008
>>>> New Revision: 662447
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=662447&view=rev
>>>> Log:
>>>> New manifest file for bcel (to be used by pack200)
>>>>
>>>> Added:
>>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/
>>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/
>>>>
>>>>
>>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>> (with props)
>>>>
>>>> Added:
>>>>
>>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>>>> URL:
>>>>
>>>>
>>> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF?rev=662447&view=auto
>>>
>>>>
>>>>
>>> ==============================================================================
>>>
>>>> ---
>>>>
>>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>>>> (added)
>>>> +++
>>>>
>>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>>>> Mon Jun 2 07:26:26 2008
>>>> @@ -0,0 +1,17 @@
>>>> +Manifest-Version: 1.0
>>>> +Bundle-ManifestVersion: 2
>>>> +Bundle-Name: BCEL
>>>> +Bundle-SymbolicName: org.apache.bcel;singleton:=true
>>>> +Bundle-Version: 5.2
>>>> +Bundle-ClassPath: bcel-5.2.jar
>>>> +Eclipse-JREBundle: true
>>>> +Import-Package: java.io,
>>>> + java.lang
>>>> +Export-Package: org.apache.bcel,
>>>> + org.apache.bcel.classfile,
>>>> + org.apache.bcel.generic,
>>>> + org.apache.bcel.util,
>>>> + org.apache.bcel.verifier,
>>>> + org.apache.bcel.verifier.exc,
>>>> + org.apache.bcel.verifier.statics,
>>>> + org.apache.bcel.verifier.structurals
>>>>
>>>> Propchange:
>>>>
>>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>>>>
>>>>
>>> ------------------------------------------------------------------------------
>>>
>>>> svn:eol-style = native
>>>>
>>>> Propchange:
>>>>
>>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>>>>
>>>>
>>> ------------------------------------------------------------------------------
>>>
>>>> svn:mime-type = text/plain
>>>>
>>>>
>>>>
>>>>
>>
>>
>>
--
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Re: svn commit: r662447 - in /harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2:
./ META-INF/ META-INF/MANIFEST.MF
Posted by Tim Ellison <t....@gmail.com>.
Sian January wrote:
> Thanks Nathan - I hadn't realised that because all the other manifests have
> java.* imports. Do you think it would be worth changing them?
Normally you would not have to import java.* packages, because they are
part of the Java platform assumed to be present to the OSGi runtime.
But, of course, we are implementing the java.* packages so we do want to
import and export them explicitly to get the modularity in the class
libraries.
The special header
Eclipse-JREBundle: true
tells Equinox not to import the java.* packages by default, so we see
breakages when the import of platform packages is missing.
Regards,
Tim
> On 03/06/2008, Nathan Beyer <nd...@apache.org> wrote:
>> BTW - java.* classes don't need to be imported; however, javax.* package do
>>
>> On Mon, Jun 2, 2008 at 9:26 AM, <sj...@apache.org> wrote:
>>
>>> Author: sjanuary
>>> Date: Mon Jun 2 07:26:26 2008
>>> New Revision: 662447
>>>
>>> URL: http://svn.apache.org/viewvc?rev=662447&view=rev
>>> Log:
>>> New manifest file for bcel (to be used by pack200)
>>>
>>> Added:
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/
>>>
>>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>> (with props)
>>>
>>> Added:
>>>
>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>> URL:
>>>
>> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF?rev=662447&view=auto
>>>
>> ==============================================================================
>>> ---
>>>
>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>> (added)
>>> +++
>>>
>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>> Mon Jun 2 07:26:26 2008
>>> @@ -0,0 +1,17 @@
>>> +Manifest-Version: 1.0
>>> +Bundle-ManifestVersion: 2
>>> +Bundle-Name: BCEL
>>> +Bundle-SymbolicName: org.apache.bcel;singleton:=true
>>> +Bundle-Version: 5.2
>>> +Bundle-ClassPath: bcel-5.2.jar
>>> +Eclipse-JREBundle: true
>>> +Import-Package: java.io,
>>> + java.lang
>>> +Export-Package: org.apache.bcel,
>>> + org.apache.bcel.classfile,
>>> + org.apache.bcel.generic,
>>> + org.apache.bcel.util,
>>> + org.apache.bcel.verifier,
>>> + org.apache.bcel.verifier.exc,
>>> + org.apache.bcel.verifier.statics,
>>> + org.apache.bcel.verifier.structurals
>>>
>>> Propchange:
>>>
>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>> ------------------------------------------------------------------------------
>>> svn:eol-style = native
>>>
>>> Propchange:
>>>
>> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
>>>
>> ------------------------------------------------------------------------------
>>> svn:mime-type = text/plain
>>>
>>>
>>>
>
>
>
Re: svn commit: r662447 - in /harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2: ./ META-INF/ META-INF/MANIFEST.MF
Posted by Sian January <si...@googlemail.com>.
Thanks Nathan - I hadn't realised that because all the other manifests have
java.* imports. Do you think it would be worth changing them?
On 03/06/2008, Nathan Beyer <nd...@apache.org> wrote:
>
> BTW - java.* classes don't need to be imported; however, javax.* package do
>
> On Mon, Jun 2, 2008 at 9:26 AM, <sj...@apache.org> wrote:
>
> > Author: sjanuary
> > Date: Mon Jun 2 07:26:26 2008
> > New Revision: 662447
> >
> > URL: http://svn.apache.org/viewvc?rev=662447&view=rev
> > Log:
> > New manifest file for bcel (to be used by pack200)
> >
> > Added:
> > harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/
> > harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/
> >
>
> > harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> > (with props)
> >
> > Added:
> >
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> > URL:
> >
> http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF?rev=662447&view=auto
> >
> >
> ==============================================================================
> > ---
> >
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> > (added)
> > +++
> >
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> > Mon Jun 2 07:26:26 2008
> > @@ -0,0 +1,17 @@
> > +Manifest-Version: 1.0
> > +Bundle-ManifestVersion: 2
> > +Bundle-Name: BCEL
> > +Bundle-SymbolicName: org.apache.bcel;singleton:=true
> > +Bundle-Version: 5.2
> > +Bundle-ClassPath: bcel-5.2.jar
> > +Eclipse-JREBundle: true
> > +Import-Package: java.io,
> > + java.lang
> > +Export-Package: org.apache.bcel,
> > + org.apache.bcel.classfile,
> > + org.apache.bcel.generic,
> > + org.apache.bcel.util,
> > + org.apache.bcel.verifier,
> > + org.apache.bcel.verifier.exc,
> > + org.apache.bcel.verifier.statics,
> > + org.apache.bcel.verifier.structurals
> >
> > Propchange:
> >
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >
> >
> ------------------------------------------------------------------------------
> > svn:eol-style = native
> >
> > Propchange:
> >
> harmony/enhanced/classlib/trunk/depends/manifests/bcel-5.2/META-INF/MANIFEST.MF
> >
> >
> ------------------------------------------------------------------------------
> > svn:mime-type = text/plain
> >
> >
> >
>
--
Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number
741598.
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU