[GitHub] nifi pull request #2145: NIFI-4352: Add CLOB and NCLOB support to PutSQL

[ijokarumawak <gi...@git.apache.org>]

GitHub user ijokarumawak opened a pull request:

    https://github.com/apache/nifi/pull/2145

    NIFI-4352: Add CLOB and NCLOB support to PutSQL

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ijokarumawak/nifi nifi-4352

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2145.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2145
    
----
commit d520c0041f3c31876de00fc9c1213f5c7d25eeda
Author: Koji Kawamura <ij...@apache.org>
Date:   2017-09-12T02:37:12Z

    NIFI-4352: Add CLOB and NCLOB support to PutSQL

----


---

[GitHub] nifi pull request #2145: NIFI-4352: Add CLOB and NCLOB support to PutSQL

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2145


---

[GitHub] nifi issue #2145: NIFI-4352: Add CLOB and NCLOB support to PutSQL

[ijokarumawak <gi...@git.apache.org>]

Github user ijokarumawak commented on the issue:

    https://github.com/apache/nifi/pull/2145
  
    Added followings:
    
    - CLOB and NCLOB support to PutSQL
    - NCLOB support to ExecuteSQL
    
    Confirmed it can insert and select CLOB and NCLOB columns. For NCLOB, I've tested Japanese characters are inserted and retrieved successfully.
    
    A template is available here in Gist:
    https://gist.github.com/ijokarumawak/451085b01349c7e6e83bcc42182ecffc
    
    ```
    CREATE TABLE clob_test (
      i INT not null,
      c CLOB,
      nc NCLOB,
      CONSTRAINT clob_test_pk PRIMARY KEY (i)
    );
    ```


---

[GitHub] nifi issue #2145: NIFI-4352: Add CLOB and NCLOB support to PutSQL

[pvillard31 <gi...@git.apache.org>]

Github user pvillard31 commented on the issue:

    https://github.com/apache/nifi/pull/2145
  
    +1, ran full build with contrib-check and made few tests with provided template. Merging to master, thanks @ijokarumawak 


---