[arrow-adbc] branch main updated: test(c/driver/postgresql): Remove errant test error message (#574)

[ko...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 47cc507  test(c/driver/postgresql): Remove errant test error message (#574)
47cc507 is described below

commit 47cc507ea07bed8f77cc0633cf46a67264706eb3
Author: William Ayd <wi...@icloud.com>
AuthorDate: Wed Apr 5 22:40:41 2023 -0700

    test(c/driver/postgresql): Remove errant test error message (#574)
    
    When running the ADBC tests against the postgres driver you currently
    get output like:
    
    ```sh
    [ RUN      ] PostgresStatementTest.Transactions
    Failure message: [libpq] Failed to execute query: could not infer schema: ERROR:  relation "bulk_ingest" does not exist
    LINE 1: SELECT * FROM bulk_ingest
                          ^
    
    [libpq] Query was: SELECT * FROM (SELECT * FROM bulk_ingest) AS ignored LIMIT 0
    WARNING:  there is no transaction in progress
    [       OK ] PostgresStatementTest.Transactions (47 ms)
    ```
    
    This was pretty confusing on first glance because the test still passes.
    On closer inspection, I don't _think_ the stderr write in the test is
    intentional
---
 c/validation/adbc_validation.cc | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/c/validation/adbc_validation.cc b/c/validation/adbc_validation.cc
index ad1bf3d..0c07db0 100644
--- a/c/validation/adbc_validation.cc
+++ b/c/validation/adbc_validation.cc
@@ -1822,10 +1822,7 @@ void StatementTest::TestTransactions() {
               })(),
               ::testing::Not(IsOkStatus(&error)));
 
-  if (error.release) {
-    std::cerr << "Failure message: " << error.message << std::endl;
-    error.release(&error);
-  }
+  if (error.release) error.release(&error);
 
   // Rollback
   ASSERT_THAT(AdbcConnectionRollback(&connection, &error), IsOkStatus(&error));