You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by cmccabe <gi...@git.apache.org> on 2017/05/24 21:32:06 UTC
[GitHub] kafka pull request #3139: MINOR: fix flakiness in testDeleteAcls
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/3139
MINOR: fix flakiness in testDeleteAcls
This call to isCompletedExceptionally introduced a race condition
because the future might not have been completed. assertFutureError
checks that the exception is present and of the correct type in any
case, so the call was not necessary.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka fix-test-deleteacls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3139.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3139
----
commit 36057c8833cbbd9908646f01fb164ce7e68d7cf9
Author: Colin P. Mccabe <cm...@confluent.io>
Date: 2017-05-24T21:29:59Z
MINOR: fix flakiness in testDeleteAcls
This call to isCompletedExceptionally introduced a race condition
because the future might not have been completed. assertFutureError
checks that the exception is present and of the correct type in any
case, so the call was not necessary.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] kafka pull request #3139: MINOR: fix flakiness in testDeleteAcls
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/kafka/pull/3139
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---