[GitHub] [superset] michael-s-molina commented on a diff in pull request #20572: feat: Renders Explore in SPA

[GitBox <gi...@apache.org>]

michael-s-molina commented on code in PR #20572:
URL: https://github.com/apache/superset/pull/20572#discussion_r913770158


##########
superset/models/slice.py:
##########
@@ -286,14 +286,14 @@ def get_query_context(self) -> Optional[QueryContext]:
 
     def get_explore_url(
         self,
-        base_url: str = "/superset/explore",
+        base_url: str = "/explore",
         overrides: Optional[Dict[str, Any]] = None,
     ) -> str:
         overrides = overrides or {}
         form_data = {"slice_id": self.id}
         form_data.update(overrides)

Review Comment:
   Thank you for spotting that! I investigated and it's trickier than it sounds. It's being used by Top N charts cache warm-up. I'll tackle this problem in a separate PR because it's not working anyway currently with `form_data_key`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org