[jira] [Commented] (CB-4907) FB - FileTransfer.java - method does not close stream

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13929989#comment-13929989 ] 

ASF subversion and git services commented on CB-4907:
-----------------------------------------------------

Commit c35ca1a5c22298542f84e372a3f9ff6da914a05b in cordova-plugin-file-transfer's branch refs/heads/dev from [~naika]
[ https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-file-transfer.git;h=c35ca1a ]

Upleveled from android port with following commits:
3c1ff16 Andrew Grieve - CB-5762 android: Fix lengthComputable set wrong for gzip downloads
8374b3d Colin Mahoney - CB-5631 Removed SimpleTrackingInputStream.read(byte[] buffer)
6f91ac3 Bas Bosman - CB-4907 Close stream when we're finished with it
651460f Christoph Neumann - CB-6000 Nginx rejects Content-Type without a space before "boundary".
35f80e4 Ian Clelland - CB-6050: Use instance method on actual file plugin object to get FileEntry to return on download


> FB - FileTransfer.java - method does not close stream
> -----------------------------------------------------
>
>                 Key: CB-4907
>                 URL: https://issues.apache.org/jira/browse/CB-4907
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android, Plugin File Transfer
>    Affects Versions: 2.9.0
>            Reporter: Peter
>            Assignee: Bas Bosman
>            Priority: Minor
>
> Resolve FindBugs reported issue in *FileTransfer.java*:
> Before
> {code}
> String line = reader.readLine();
> while(line != null)
> {
>     bodyBuilder.append(line);
>     line = reader.readLine();
>     if(line != null)
>         bodyBuilder.append('\n');
> }
> body = bodyBuilder.toString();
> {code}
> After
> {code}
> try {
>     String line = reader.readLine();
>     while(line != null) {
>         bodyBuilder.append(line);
>         line = reader.readLine();
>         if(line != null) {
>             bodyBuilder.append('\n');
>         }
>     }
>     body = bodyBuilder.toString();
> } finally {
>     reader.close();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)