You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Gili (JIRA)" <ji...@apache.org> on 2019/01/26 19:41:00 UTC
[jira] [Created] (MJAVADOC-570) --add-modules expects
comma-separated arguments
Gili created MJAVADOC-570:
-----------------------------
Summary: --add-modules expects comma-separated arguments
Key: MJAVADOC-570
URL: https://issues.apache.org/jira/browse/MJAVADOC-570
Project: Maven Javadoc Plugin
Issue Type: Bug
Components: javadoc
Affects Versions: 3.1.0
Reporter: Gili
It's quicker for me to explain this problem that produce a minimal testcase for it. In AbstractJavadocMojo line 5079 we invoke:
{code:java}
addArgIfNotEmpty( arguments, "--add-modules", JavadocUtil.quotedPathArgument(addModulesLine ) );{code}
This gets converted to {{addArgIfNotEmpty()}} with {{splitValue=true}} which means that comma-separated values get converted to newline-separated values.
{{--add-modules}} does not like this and does not consume the subsequent arguments (they probably get treated as source files instead).
We should be invoking {{addArgIfNotEmpty()}} with {{splitValue=false}} instead.
If I provide a PR for this, do you still need a testcase?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)