You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "airborne12 (via GitHub)" <gi...@apache.org> on 2024/06/11 13:23:55 UTC
[PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
airborne12 opened a new pull request, #36144:
URL: https://github.com/apache/doris/pull/36144
## Proposed changes
Issue Number: close #xxx
Add ownership flag to Field's TokenStream value and Analyzer's Reader value, free them when tokenizer finalize.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye merged PR #36144:
URL: https://github.com/apache/doris/pull/36144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162068636
TeamCity be ut coverage result:
Function Coverage: 36.41% (8985/24680)
Line Coverage: 27.95% (73469/262823)
Region Coverage: 27.38% (38103/139177)
Branch Coverage: 24.00% (19343/80586)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d19181efc42b46abd8c22a3dbddc52a57f3ce735_d19181efc42b46abd8c22a3dbddc52a57f3ce735/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1635733467
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -421,7 +424,6 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
// if this array is null, we just ignore to write inverted index
RETURN_IF_ERROR(add_document());
_doc->clear();
- _CLDELETE(ts);
Review Comment:
The field now takes ownership of the TokenStream, eliminating the need for manual deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2160760211
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2161991844
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2160775525
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162003338
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "xiaokang (via GitHub)" <gi...@apache.org>.
xiaokang commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1634963439
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -404,12 +404,15 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
_parser_type != InvertedIndexParserType::PARSER_NONE) {
// in this case stream need to delete after add_document, because the
// stream can not reuse for different field
+ bool own_token_stream = true;
Review Comment:
Only used once
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162070957
<details>
<summary>ClickBench: <b>Total hot run time: 30.77 s</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d19181efc42b46abd8c22a3dbddc52a57f3ce735, data reload: false
query1 0.04 0.04 0.03
query2 0.08 0.04 0.04
query3 0.23 0.04 0.05
query4 1.67 0.07 0.07
query5 0.50 0.49 0.47
query6 1.12 0.72 0.72
query7 0.02 0.01 0.01
query8 0.06 0.04 0.04
query9 0.54 0.49 0.48
query10 0.55 0.55 0.54
query11 0.14 0.12 0.11
query12 0.14 0.11 0.12
query13 0.59 0.59 0.60
query14 0.77 0.76 0.80
query15 0.83 0.81 0.80
query16 0.36 0.36 0.37
query17 0.98 0.95 1.01
query18 0.22 0.24 0.24
query19 1.76 1.70 1.71
query20 0.01 0.01 0.02
query21 15.42 0.66 0.66
query22 4.22 6.76 2.34
query23 18.26 1.46 1.23
query24 2.10 0.22 0.22
query25 0.16 0.09 0.08
query26 0.27 0.17 0.17
query27 0.08 0.08 0.08
query28 13.21 1.01 0.99
query29 12.60 3.26 3.25
query30 0.26 0.07 0.07
query31 2.86 0.38 0.38
query32 3.29 0.46 0.46
query33 2.91 2.93 2.91
query34 17.11 4.39 4.38
query35 4.49 4.45 4.47
query36 0.66 0.45 0.47
query37 0.18 0.16 0.15
query38 0.14 0.14 0.15
query39 0.04 0.04 0.04
query40 0.18 0.16 0.14
query41 0.10 0.04 0.04
query42 0.05 0.04 0.05
query43 0.04 0.04 0.03
Total cold run time: 109.24 s
Total hot run time: 30.77 s
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1635731710
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -421,7 +424,6 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
// if this array is null, we just ignore to write inverted index
RETURN_IF_ERROR(add_document());
_doc->clear();
- _CLDELETE(ts);
Review Comment:
The Field now takes ownership of the TokenStream, eliminating the need for manual deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "qidaye (via GitHub)" <gi...@apache.org>.
qidaye commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2161992876
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "amorynan (via GitHub)" <gi...@apache.org>.
amorynan commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1635673756
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -421,7 +424,6 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
// if this array is null, we just ignore to write inverted index
RETURN_IF_ERROR(add_document());
_doc->clear();
- _CLDELETE(ts);
Review Comment:
why delete here will make memory leak?
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -421,7 +424,6 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
// if this array is null, we just ignore to write inverted index
RETURN_IF_ERROR(add_document());
_doc->clear();
- _CLDELETE(ts);
Review Comment:
why delete here will make memory leak?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1634999368
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -404,12 +404,15 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
_parser_type != InvertedIndexParserType::PARSER_NONE) {
// in this case stream need to delete after add_document, because the
// stream can not reuse for different field
+ bool own_token_stream = true;
Review Comment:
by the way, no need more case, p0 case can cause the memory leak.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on code in PR #36144:
URL: https://github.com/apache/doris/pull/36144#discussion_r1634998711
##########
be/src/olap/rowset/segment_v2/inverted_index_writer.cpp:
##########
@@ -404,12 +404,15 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
_parser_type != InvertedIndexParserType::PARSER_NONE) {
// in this case stream need to delete after add_document, because the
// stream can not reuse for different field
+ bool own_token_stream = true;
Review Comment:
yes, to make code more readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162057079
<details>
<summary>TPC-H: <b>Total hot run time: 40301 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d19181efc42b46abd8c22a3dbddc52a57f3ce735, data reload: false
------ Round 1 ----------------------------------
q1 17599 4579 4285 4285
q2 2019 192 191 191
q3 10465 1140 1043 1043
q4 10184 814 768 768
q5 7466 2739 2715 2715
q6 223 138 137 137
q7 971 612 600 600
q8 9222 2066 2051 2051
q9 8819 6527 6501 6501
q10 9020 3721 3687 3687
q11 446 234 228 228
q12 502 230 223 223
q13 17762 2947 2975 2947
q14 259 226 224 224
q15 526 464 477 464
q16 520 387 369 369
q17 975 686 719 686
q18 8391 7831 7836 7831
q19 7766 1442 1339 1339
q20 697 332 312 312
q21 5168 3359 4117 3359
q22 400 350 341 341
Total cold run time: 119400 ms
Total hot run time: 40301 ms
----- Round 2, with runtime_filter_mode=off -----
q1 4684 4477 4434 4434
q2 393 270 258 258
q3 3001 2798 2902 2798
q4 1891 1671 1676 1671
q5 5550 5541 5583 5541
q6 218 128 130 128
q7 2171 1796 1821 1796
q8 3325 3400 3384 3384
q9 8743 8712 8707 8707
q10 4082 3858 3788 3788
q11 586 483 499 483
q12 812 630 659 630
q13 17346 3008 3034 3008
q14 312 279 272 272
q15 532 499 478 478
q16 486 425 428 425
q17 1820 1548 1510 1510
q18 8012 7779 7615 7615
q19 1753 1571 1648 1571
q20 2680 1842 1857 1842
q21 6516 4738 4976 4738
q22 769 558 540 540
Total cold run time: 75682 ms
Total hot run time: 55617 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162066819
<details>
<summary>TPC-DS: <b>Total hot run time: 172398 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d19181efc42b46abd8c22a3dbddc52a57f3ce735, data reload: false
query1 822 391 374 374
query2 6307 2443 2320 2320
query3 6397 208 212 208
query4 18779 17329 17216 17216
query5 3798 480 474 474
query6 254 163 161 161
query7 4467 306 300 300
query8 328 300 295 295
query9 8485 2355 2338 2338
query10 563 311 320 311
query11 10483 9960 9998 9960
query12 150 87 88 87
query13 1603 378 377 377
query14 9290 6755 8012 6755
query15 231 192 184 184
query16 7724 281 285 281
query17 1708 576 568 568
query18 1678 273 275 273
query19 190 153 158 153
query20 92 81 82 81
query21 217 136 129 129
query22 4174 4011 4001 4001
query23 33569 33785 33525 33525
query24 11123 2826 2773 2773
query25 615 372 369 369
query26 1223 152 151 151
query27 2822 323 319 319
query28 7209 2043 2013 2013
query29 889 641 616 616
query30 255 154 153 153
query31 951 750 712 712
query32 97 53 55 53
query33 748 278 278 278
query34 906 481 470 470
query35 729 644 611 611
query36 1100 915 965 915
query37 162 68 67 67
query38 2857 2712 2770 2712
query39 827 807 794 794
query40 217 125 126 125
query41 52 51 55 51
query42 122 99 100 99
query43 595 568 535 535
query44 1250 764 733 733
query45 195 163 167 163
query46 1103 705 721 705
query47 1841 1766 1773 1766
query48 379 309 293 293
query49 867 424 402 402
query50 760 396 397 396
query51 6789 6616 6693 6616
query52 105 94 90 90
query53 358 298 291 291
query54 885 464 447 447
query55 77 75 76 75
query56 280 255 258 255
query57 1153 1048 1041 1041
query58 256 236 285 236
query59 3206 3260 3286 3260
query60 308 282 269 269
query61 93 91 86 86
query62 626 436 431 431
query63 316 295 294 294
query64 8857 2213 1771 1771
query65 3153 3154 3092 3092
query66 949 318 332 318
query67 15495 14782 14811 14782
query68 4484 558 547 547
query69 558 454 426 426
query70 1143 1146 1178 1146
query71 409 279 271 271
query72 6863 5034 5180 5034
query73 748 334 330 330
query74 5814 5414 5535 5414
query75 3386 2664 2637 2637
query76 2566 939 1010 939
query77 447 305 304 304
query78 10287 9816 9684 9684
query79 2432 529 516 516
query80 1276 470 462 462
query81 573 226 225 225
query82 783 102 107 102
query83 253 169 167 167
query84 253 91 85 85
query85 1503 277 269 269
query86 459 324 323 323
query87 3261 3063 3067 3063
query88 4078 2465 2495 2465
query89 473 385 391 385
query90 1847 187 188 187
query91 127 99 100 99
query92 62 51 48 48
query93 1802 509 505 505
query94 1270 188 182 182
query95 405 328 312 312
query96 588 276 265 265
query97 3170 3026 2973 2973
query98 219 211 200 200
query99 1158 840 834 834
Total cold run time: 266806 ms
Total hot run time: 172398 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2162207716
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memeory leak in inverted index writer for array values [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2161987637
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Fix](inverted index) fix memory leak in inverted index writer for array values [doris]
Posted by "airborne12 (via GitHub)" <gi...@apache.org>.
airborne12 commented on PR #36144:
URL: https://github.com/apache/doris/pull/36144#issuecomment-2161998728
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org