You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/05/16 05:16:38 UTC
Review Request 67148: ATLAS-2685: Impose displayName restrictions on
Glossary, Term & Category
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/
-----------------------------------------------------------
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Bugs: ATLAS-2685
https://issues.apache.org/jira/browse/ATLAS-2685
Repository: atlas
Description
-------
Glossary & term name can only have letters, spaces, underscores and dashes
Category can only have letters and spaces
Added appropriate error codes around this check
Diffs
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
Diff: https://reviews.apache.org/r/67148/diff/1/
Testing
-------
PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
Thanks,
Apoorv Naik
Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions
on Glossary, Term & Category
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203205
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 139 (patched)
<https://reviews.apache.org/r/67148/#comment285299>
I see qualified name as a unique identifier, being derived from referenencable. In one of our meeting we talked of using the guid and name here. I thought we talked of deriving a path attribute post v1 - using a new generic Atlas mechanism.
Display name might not be unique, as we want to support categories with the same name. I see display name is not the hierarchical path. It should be the name.
On the policing I wonder what happens with janus keywords and whether mixed case are viewed as different.
- David Radley
On May 16, 2018, 6:11 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 6:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-2685
> https://issues.apache.org/jira/browse/ATLAS-2685
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
>
> Added appropriate error codes around this check
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
>
>
> Diff: https://reviews.apache.org/r/67148/diff/2/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions
on Glossary, Term & Category
Posted by David Radley <da...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203206
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 69 (patched)
<https://reviews.apache.org/r/67148/#comment285300>
I am wondering why the display name is restricted with these characters - does it cause a probem? Where would you use the display name in a dotted qualfied name? I assume the display name could be Janaese characters - I am not sure it would be appropriate to concatinate dots and a Japanese string.
If you want to restrict it, presumably you need to remove all punctuation content in all languages.
I suggest you be extra safe for now and only allow upper&lower case case letters and blanks - unless you already have nls requirements.
Then extend as requirements come in. Out of interest I assume that the Janus keywords checking could effect what term names can be used.
Fyi translation is covered in the open metadata model with relationships.
- David Radley
On May 16, 2018, 6:11 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 6:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-2685
> https://issues.apache.org/jira/browse/ATLAS-2685
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
>
> Added appropriate error codes around this check
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
>
>
> Diff: https://reviews.apache.org/r/67148/diff/2/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions
on Glossary, Term & Category
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203202
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On May 16, 2018, 6:11 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 6:11 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-2685
> https://issues.apache.org/jira/browse/ATLAS-2685
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
>
> Added appropriate error codes around this check
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
>
>
> Diff: https://reviews.apache.org/r/67148/diff/2/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
>
>
> Thanks,
>
> Apoorv Naik
>
>
Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions
on Glossary, Term & Category
Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/
-----------------------------------------------------------
(Updated May 16, 2018, 6:11 a.m.)
Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
Changes
-------
ADdressed review comments
Bugs: ATLAS-2685
https://issues.apache.org/jira/browse/ATLAS-2685
Repository: atlas
Description
-------
Glossary & term name can only have letters, spaces, underscores and dashes
Category can only have letters and spaces
Added appropriate error codes around this check
Diffs (updated)
-----
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
Diff: https://reviews.apache.org/r/67148/diff/2/
Changes: https://reviews.apache.org/r/67148/diff/1-2/
Testing
-------
PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
Thanks,
Apoorv Naik
Re: Review Request 67148: ATLAS-2685: Impose displayName restrictions
on Glossary, Term & Category
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67148/#review203200
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 70 (patched)
<https://reviews.apache.org/r/67148/#comment285298>
Restricting names with this pattern wouldn't allow international characters - which may not be desirable. I would suggest to only disallow specific characters that are interpretted by Atlas - for example '@' and '.', which are used to form qualifiedName for terms/categories/glossaries.
- Madhan Neethiraj
On May 16, 2018, 5:16 a.m., Apoorv Naik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67148/
> -----------------------------------------------------------
>
> (Updated May 16, 2018, 5:16 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-2685
> https://issues.apache.org/jira/browse/ATLAS-2685
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Glossary & term name can only have letters, spaces, underscores and dashes
> Category can only have letters and spaces
>
> Added appropriate error codes around this check
>
>
> Diffs
> -----
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 3a609786a
> repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java bc9fe2a2e
> repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java f66165050
>
>
> Diff: https://reviews.apache.org/r/67148/diff/1/
>
>
> Testing
> -------
>
> PreCommit: https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/408/console
>
>
> Thanks,
>
> Apoorv Naik
>
>