Re: [PR] Permitting airflow kerberos to run in different modes [airflow]

["amoghrajesh (via GitHub)" <gi...@apache.org>]

amoghrajesh commented on code in PR #35146:
URL: https://github.com/apache/airflow/pull/35146#discussion_r1370461767


##########
airflow/cli/commands/kerberos_command.py:
##########
@@ -33,6 +34,17 @@ def kerberos(args):
     """Start a kerberos ticket renewer."""
     print(settings.HEADER)
 
+    mode_mapping = {
+        "daemon": KerberosMode.DAEMON,
+        "one-time": KerberosMode.ONE_TIME,
+    }
+    if args.mode:

Review Comment:
   Nevermind. I found it and fixed it



##########
docs/apache-airflow/security/kerberos.rst:
##########
@@ -100,6 +100,18 @@ Launch the ticket renewer by
     # run ticket renewer
     airflow kerberos
 
+To support more advanced deployment models for using kerberos in daemon or one-time fashion,
+you can specify the mode while running the ``airflow kerberos`` as either "daemon" or "one-time".
+
+* daemon: The airflow kerberos process will run forever
+* one-time: The airflow kerberos will run once and exit. In case of failure the main task won't spin up.
+
+Example usages:
+``
+airflow kerberos --mode daemon
+airflow kerberos --mode one-time

Review Comment:
   Added some examples also here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org