[jira] Updated: (WW-2103) Invalid Javascript generated for StringLength validator

["Florent Ramière (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/struts/browse/WW-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Florent Ramière updated WW-2103:
--------------------------------

    Attachment: form-close-validate.ftl.patch

I confirm the bug, this error was scattered across the validation.
Freemarker ouputs number in the default local by default, in order to have javascript compliant number we need to request the string value using the ?string built-in method.
Note that I fixed also a bug in the stringlength method where the validator was not triggered when the field value is empty

> Invalid Javascript generated for StringLength validator 
> --------------------------------------------------------
>
>                 Key: WW-2103
>                 URL: https://issues.apache.org/struts/browse/WW-2103
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.0.9
>         Environment: NetBeans IDE 5.5.1 (Bundled Tomcat 5.5.17), Java 1.6
>            Reporter: Jeremy Mikola
>            Priority: Minor
>         Attachments: form-close-validate.ftl.patch
>
>
> I am attempting to use the StringLength validator for an action's "save" alias, to ensure that a text-field input is between 3 and 1024 characters long (the minLength and maxLength params, respectively).  When testing the validation, I noticed that strings of any length were being rejected by the client-side Javascript validation (I am using the xhtml theme).  Looking at the generated Javascript code in the page source, it appears the problem is that my maxLength parameter is being printed with locale formatting (as it is in when substituted into my error message), rather than as a raw number:
>     if(value.length > 0 && (
>             (3 > -1 && value.length < 3) ||
>             (1,024 > -1 && value.length > 1,024)
>             )) {
>         addError(field, error);
>         errors = true;
>     }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.