You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/04/05 13:01:47 UTC
[GitHub] [maven-checkstyle-plugin] juliendemaziere opened a new pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
juliendemaziere opened a new pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46
I did a little more than then JIRA https://issues.apache.org/jira/browse/MCHECKSTYLE-393 : I updated all doxia and then fixed dependencies and Java code accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] juliendemaziere commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
juliendemaziere commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607111994
##########
File path: pom.xml
##########
@@ -243,6 +218,12 @@ under the License.
<version>${mavenVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ <version>1.7.30</version>
Review comment:
I removed this dependency as it added many unwanted logs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607117049
##########
File path: pom.xml
##########
@@ -234,7 +209,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
- <version>2.1</version>
+ <version>3.3.0</version>
Review comment:
check https://maven.apache.org/plugin-testing/maven-plugin-testing-harness/dependency-management.html for maven-core dependency. The latest version depends on Maven 3.2.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#issuecomment-813388415
many CI build failed - please check locally if `mvn verify -Prun-its` run was successfull.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] juliendemaziere commented on pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
juliendemaziere commented on pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#issuecomment-813474945
Thank you for your comments/feedbacks, it is my first PR on an open source project :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#issuecomment-813486277
I'll split changes here into 2 separate commits - one related to upgrading the minimum required Maven version and to changes related to Doxia.
small question related to commit message - now It says that the author is "docker host internal" is it expected?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607082424
##########
File path: pom.xml
##########
@@ -234,7 +209,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
- <version>2.1</version>
+ <version>3.3.0</version>
Review comment:
3.1.0 max
##########
File path: pom.xml
##########
@@ -243,6 +218,12 @@ under the License.
<version>${mavenVersion}</version>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-log4j12</artifactId>
+ <version>1.7.30</version>
Review comment:
1.7.29 max
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] juliendemaziere commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
juliendemaziere commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607112735
##########
File path: pom.xml
##########
@@ -234,7 +209,7 @@ under the License.
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
- <version>2.1</version>
+ <version>3.3.0</version>
Review comment:
Done, where can I find the maximum version(s) not to exceed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607082204
##########
File path: pom.xml
##########
@@ -65,9 +65,9 @@ under the License.
<properties>
<!-- Because Checkstyle 7+ requires Java 8 -->
<javaVersion>8</javaVersion>
- <mavenVersion>3.0</mavenVersion>
+ <mavenVersion>3.6.3</mavenVersion>
Review comment:
please do not update the minimum required Maven version to the latest available maven. Currently, our minimum should be 3.1.1. Please also do not update everything in one ticket/PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz closed pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz closed pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] slachiewicz commented on pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#issuecomment-813483699
Running on our CI platform: https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-393v2/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] juliendemaziere commented on a change in pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
juliendemaziere commented on a change in pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#discussion_r607171264
##########
File path: pom.xml
##########
@@ -65,9 +65,9 @@ under the License.
<properties>
<!-- Because Checkstyle 7+ requires Java 8 -->
<javaVersion>8</javaVersion>
- <mavenVersion>3.0</mavenVersion>
+ <mavenVersion>3.6.3</mavenVersion>
Review comment:
Done, I had to add some dependencies (sisu) to make it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-checkstyle-plugin] juliendemaziere commented on pull request #46: [MCHECKSTYLE-393] update doxia to 1.9.2
Posted by GitBox <gi...@apache.org>.
juliendemaziere commented on pull request #46:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/46#issuecomment-813389049
Ok I will fix the versions and run the IT localy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org