[jira] [Commented] (SLIDER-668) "slider package" CLI command to offer package management operations

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255945#comment-14255945 ] 

Ted Yu commented on SLIDER-668:
-------------------------------

{code}
-    if (ACTION_INSTALL_PACKAGE.equals(action)) {
-      exitCode = actionInstallPkg(serviceArgs.getActionInstallPackageArgs());
+    if (ACTION_PACKAGE.equals(action)) {
{code}
'install-package' command would no longer be supported ? Can backward compatibility with 0.60 release be kept ?
{code}
+  public int actionPackage(ActionPackageArgs installPkgInfo) throws YarnException, IOException{
{code}
Please name the parameter consistently with its type.
{code}
+    println("List of application with its package name and path");
{code}
Use Logger (log) instead of println().
{code}
+    sliderFileSystem.getFileSystem().delete(pkgPath, true);
{code}
Check return value and verify the package is deleted.

> "slider package" CLI command to offer package management operations
> -------------------------------------------------------------------
>
>                 Key: SLIDER-668
>                 URL: https://issues.apache.org/jira/browse/SLIDER-668
>             Project: Slider
>          Issue Type: New Feature
>          Components: client
>    Affects Versions: Slider 0.60
>            Reporter: Steve Loughran
>         Attachments: SLIDER-668.1.patch
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> we currently have one package operation: {{slider install-package}}
> There are more things we may want to do with packages —so should offer a {{slider package}} command to support the operations
> # {{install}}: install the package (available today)
> # {{list}}
> # {{delete}}
> # {{instances}} (?): grep application configs to list all app instances referencing a package



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)