[GitHub] [couchdb] nickva commented on a diff in pull request #4608: Add a few more commit and query engine metrics

["nickva (via GitHub)" <gi...@apache.org>]

nickva commented on code in PR #4608:
URL: https://github.com/apache/couchdb/pull/4608#discussion_r1199648230


##########
src/couch/priv/stats_descriptions.cfg:
##########
@@ -290,6 +302,30 @@
     {type, histogram},
     {desc, <<"duration of validate_doc_update function calls">>}
 ]}.
+{[couchdb, query_server, acquired_processes], [
+    {type, counter},
+    {desc, <<"number of acquired external processes">>}
+]}.
+{[couchdb, query_server, process_starts], [
+    {type, counter},
+    {desc, <<"number of os process starts">>}

Review Comment:
   Good point. It was OS at first, but then I noticed the surrounding descriptions were all lower-cased so went with that pattern, higher up in the file we do have a few  "HTTP" and "CouchDB" so "OS" would work. I'll change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org