You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/07/05 12:16:54 UTC

[GitHub] [incubator-dolphinscheduler] wuchunfu opened a new issue #3139: [PROPOSAL] Datasource selection changes from radio to select

wuchunfu opened a new issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139


     I suggest changing the previous method of selecting data sources into drop-down ones. Otherwise, once more data sources are added, the whole page will look bloated.
   
   Change the way you selected the data source before
   
   ![image](https://user-images.githubusercontent.com/29206593/86532393-2af5a880-befc-11ea-8e68-d542e59e332c.png)
   
   Change the way you selected the data source after
   
   ![image](https://user-images.githubusercontent.com/29206593/86532404-39dc5b00-befc-11ea-81e8-f5cf8888e380.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] wuchunfu commented on issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139#issuecomment-653897576


   I will submit a pull request later. Do I submit it to the dev branch?
   
   
   
   
   Best Regards
   
   
   wuchunfu
   2020-07-05
   
   
   
   
   
   ------------------&nbsp;Original&nbsp;------------------
   From:&nbsp;"dailidong"<notifications@github.com&gt;;
   Date:&nbsp;Sun, Jul 5, 2020 10:28 PM
   To:&nbsp;"apache/incubator-dolphinscheduler"<incubator-dolphinscheduler@noreply.github.com&gt;;
   Cc:&nbsp;"Musk"<319355703@qq.com&gt;;"Author"<author@noreply.github.com&gt;;
   Subject:&nbsp;Re: [apache/incubator-dolphinscheduler] [PROPOSAL] Datasource selection changes from radio to select (#3139)
   
   
   
   
   
    
   good job,  could you submit a PR ?
    
   —
   You are receiving this because you authored the thread.
   Reply to this email directly, view it on GitHub, or unsubscribe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] qiaozhanwei closed issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
qiaozhanwei closed issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139#issuecomment-653895534


   good suggestion， glad to see you will implement it


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139#issuecomment-653899239


   yes，please submit PR to dev branch
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] wuchunfu commented on issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139#issuecomment-653881592


   I have implemented this function.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-dolphinscheduler] dailidong commented on issue #3139: [PROPOSAL] Datasource selection changes from radio to select

Posted by GitBox <gi...@apache.org>.
dailidong commented on issue #3139:
URL: https://github.com/apache/incubator-dolphinscheduler/issues/3139#issuecomment-653895645


   good job,  could you submit a PR ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org