You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2021/09/21 19:58:00 UTC
[jira] [Comment Edited] (IO-750) FileUtils.iterateFiles lists
directorys with WildcardFileFilter *
[ https://issues.apache.org/jira/browse/IO-750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17418272#comment-17418272 ]
Gary D. Gregory edited comment on IO-750 at 9/21/21, 7:57 PM:
--------------------------------------------------------------
Hi [~xf01213] & [~sepe81]:
If you want to exclude directories, you'll need to use WildcardFilter: [https://javadoc.io/doc/commons-io/commons-io/2.8.0/org/apache/commons/io/filefilter/WildcardFilter.html]
The newer class WildcardFileFilter was always documented to select files and directories: [https://javadoc.io/doc/commons-io/commons-io/2.8.0/org/apache/commons/io/filefilter/WildcardFileFilter.html]:
"This filter selects files and directories based on one or more wildcards."
It looks to have been documented as such as far back as 1.3.2, which is as old as javadoc.io seems to go: [https://javadoc.io/doc/commons-io/commons-io/1.3.2/org/apache/commons/io/filefilter/WildcardFileFilter.html]
This looks to be the case that the code was not properly tested.
was (Author: garydgregory):
Hi [~xf01213] & [~sepe81]:
If you want to exclude directories, you'll need to use WildcardFilter: [https://javadoc.io/doc/commons-io/commons-io/2.8.0/org/apache/commons/io/filefilter/WildcardFilter.html]
The newer class WildcardFileFilter was always documented to select files and directories: [https://javadoc.io/doc/commons-io/commons-io/2.8.0/org/apache/commons/io/filefilter/WildcardFileFilter.html]:
"This filter selects files and directories based on one or more wildcards."
It looks to have been documented as such as far back as 1.3.2, which is as old as javadoc.io seems to go: [https://javadoc.io/doc/commons-io/commons-io/1.3.2/org/apache/commons/io/filefilter/WildcardFileFilter.html]
This this looks to be the case that the code was not properly tested.
> FileUtils.iterateFiles lists directorys with WildcardFileFilter *
> -----------------------------------------------------------------
>
> Key: IO-750
> URL: https://issues.apache.org/jira/browse/IO-750
> Project: Commons IO
> Issue Type: Bug
> Affects Versions: 2.9.0
> Reporter: Sita Geßner
> Priority: Major
>
> After updating commons-io from 2.8.0 to 2.9.0 the method FileUtils.iterateFiles also returns directories.
> Codeexample:
> {code:java}
> final File directory = new File(FileUtils.getTempDirectory(), "TEST");
> directory.mkdir();
> new File(directory, "TEST").mkdir();
> new File(directory, "test.txt").createNewFile();
> final IOFileFilter filter = new WildcardFileFilter("*", IOCase.INSENSITIVE);
> for (final Iterator<File> itFiles = FileUtils.iterateFiles(directory, filter, null); itFiles
> .hasNext();) {
> final File file = itFiles.next();
> System.out.println(file.getAbsolutePath());
> }
> {code}
> result in version 2.8.0:
> {noformat}
> /tmp/TEST/test.txt
> {noformat}
> result from version 2.9.0:
> {noformat}
> /tmp/TEST/test.txt
> /tmp/TEST/TEST
> {noformat}
> iterateFiles shouldn't return directories.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)