You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/06 19:40:04 UTC
[GitHub] [superset] aguspina opened a new issue #12987: Trouble adding Argentina geojson to country map legacy plugin
aguspina opened a new issue #12987:
URL: https://github.com/apache/superset/issues/12987
I connected superset with a local modify version of the superset-ui plugin legacy-country map but I got this viz:
<img width="783" alt="Screen Shot 2021-02-06 at 16 34 26" src="https://user-images.githubusercontent.com/4105740/107128049-6cd33c80-6899-11eb-8d2e-eda969ef041f.png">
I'm the the right geojson generated from the file downloaded from https://www.diva-gis.org/gdata with de ISO column updated to follow de ISO 3166-2 standard.
If someone help me solve this, I will make the corresponding PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774560090
@aguspina can you provide detailed steps to reproduce this issue? thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mayurnewase commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
mayurnewase commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-778746914
I think the file is in a different format, I found this pr fixes Bulgaria map, which suffers from a similar issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774531131
Here is the geojson file https://gist.github.com/aguspina/570fe8c52bb9628f38618ad9b037f4e7
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina edited a comment on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina edited a comment on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774561488
Of course :)
I added this line to the countries.js
```python
import argentina from 'file-loader!./countries/argentina.geojson';
```
The argentina.geojson file into the countries folder and added argentina to the choices in the controlPanel.ts file
```typescript
label: t('Country Name'),
default: 'France',
choices: [
'Argentina',
```
And I had to change the package json in superset-frontend to poniny to my local fork of superset-ui plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-780800470
Hi @djok thanks for your help. I think the geojson you shared to me is malformed, it is duplicated and truncated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] djok commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
djok commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-779053107
Please test this geoJson https://gist.github.com/djok/b53cbbb4f76ecaa8499fdafbc1cac040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina edited a comment on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina edited a comment on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774561488
Of course :)
I added this line to the countries.js
```python
import argentina from 'file-loader!./countries/argentina.geojson';
```
The argentina.geojson file into the countries folder and added argentina to the choices in the controlPanel.ts file
```typescript
label: t('Country Name'),
default: 'France',
choices: [
'Argentina',
```
And I had to chance the package json in superset-frontend to poniny to my local fork of superset-ui plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] djok edited a comment on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
djok edited a comment on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-779053107
Please test this geoJson https://gist.github.com/djok/b53cbbb4f76ecaa8499fdafbc1cac040
I used mapshaper.org to simplify and fix overlapping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-776483247
@aguspina thanks for the details. @mayurnewase do you mind taking a look this issue? 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina edited a comment on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina edited a comment on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774561488
Of course :)
I added this line to the countries.js
```python
import argentina from 'file-loader!./countries/argentina.geojson';
```
The argentina.geojson file into the countries folder and added argentina to the choices in the controlPanel.ts file
```typescript
label: t('Country Name'),
default: 'France',
choices: [
'Argentina',
```
And I had to change the package json in superset-frontend to ponint to my local fork of superset-ui plugins
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] bdiouih commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
bdiouih commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-784978353
> Please test this geoJson https://gist.github.com/djok/b53cbbb4f76ecaa8499fdafbc1cac040
>
> I used mapshaper.org to simplify and fix overlapping
I have exactly the similar issue with Afghanistan geojson file.
How can this be solved exactly : how can it be simplified and overlapping fixed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aguspina commented on issue #12987: Trouble adding Argentina geojson to country map legacy plugin
Posted by GitBox <gi...@apache.org>.
aguspina commented on issue #12987:
URL: https://github.com/apache/superset/issues/12987#issuecomment-774561488
Of course :)
I added this line to the countries.js
```python
import argentina from 'file-loader!./countries/argentina.geojson';
```
The argentina.geojson file into the countries folder and added argentina to the choices in the controlPanel.ts file
```typescript
label: t('Country Name'),
default: 'France',
choices: [
'Argentina',
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org