You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/05 15:44:56 UTC
[GitHub] [pulsar] eolivelli commented on a diff in pull request #14102: PIP-144: Making SchemaRegistry implementation configurable
eolivelli commented on code in PR #14102:
URL: https://github.com/apache/pulsar/pull/14102#discussion_r842947287
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1285,6 +1286,13 @@ private SchemaStorage createAndStartSchemaStorage() throws Exception {
return schemaStorage;
}
+ private void setSchemaRegistryName(SchemaStorage schemaStorage) {
+ String schemaRegistryClassName = "org.apache.pulsar.broker.service.schema.DefaultSchemaRegistryService";
Review Comment:
please create a constant
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java:
##########
@@ -1285,6 +1286,13 @@ private SchemaStorage createAndStartSchemaStorage() throws Exception {
return schemaStorage;
}
+ private void setSchemaRegistryName(SchemaStorage schemaStorage) {
Review Comment:
the name is not very clear
what about 'ensureSchemaRegistryClassName' ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org