[GitHub] [flink] tillrohrmann commented on a change in pull request #11010: [FLINK-15836][k8s] Throw fatal exception when the pods watcher in Fabric8FlinkKubeClient is closed

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #11010: [FLINK-15836][k8s] Throw fatal exception when the pods watcher in Fabric8FlinkKubeClient is closed
URL: https://github.com/apache/flink/pull/11010#discussion_r375378254
 
 

 ##########
 File path: flink-kubernetes/src/main/java/org/apache/flink/kubernetes/kubeclient/Fabric8FlinkKubeClient.java
 ##########
 @@ -279,7 +280,7 @@ public void eventReceived(Action action, Pod pod) {
 
 			@Override
 			public void onClose(KubernetesClientException e) {
-				LOG.error("The pods watcher is closing.", e);
+				throw new FlinkRuntimeException("The pods watcher should not be closed.", e);
 
 Review comment:
   Could you explain how this is solving the problem @wangyang0918? Looking at the code, this should throw an exception in some `KubernetesClient` internal thread which does not guarantee that it is properly handled. I think it should rather trigger some behaviour in `KubernetesResourceManager` (e.g. trying to reconnect or in the worst case to fail with a descriptive error message).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services