You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2016/02/02 15:54:51 UTC
Review Request 43091: Renamed a variable and updated a comment for
clarity.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43091/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4443
https://issues.apache.org/jira/browse/MESOS-4443
Repository: mesos
Description
-------
See summary.
Diffs
-----
include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79
src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3
src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88
src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0
Diff: https://reviews.apache.org/r/43091/diff/
Testing
-------
`make check`
Thanks,
Alexander Rukletsov
Re: Review Request 43091: Renamed a variable and updated a comment for
clarity.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43091/#review117813
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 182)
<https://reviews.apache.org/r/43091/#comment179075>
Do we need to update the comments to `recovered agents`?
src/master/allocator/mesos/hierarchical.cpp (line 183)
<https://reviews.apache.org/r/43091/#comment179076>
Just some of my thinking, I think that here the variable `expectedAgentCount` is better than `recoveredAgentCount`, because here the allocator is `expecting` to get a `desired` number of agents gets recovered before proceed.
src/master/allocator/mesos/hierarchical.cpp (line 186)
<https://reviews.apache.org/r/43091/#comment179077>
what about the comments here for `expected agents`? need update?
- Guangya Liu
On Feb. 2, 2016, 2:54 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43091/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 2:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4443
> https://issues.apache.org/jira/browse/MESOS-4443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79
> src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3
> src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88
> src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
> src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
> src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0
>
> Diff: https://reviews.apache.org/r/43091/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 43091: Renamed a variable and updated a comment for
clarity.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43091/#review117422
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43091]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 2, 2016, 2:54 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43091/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 2:54 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4443
> https://issues.apache.org/jira/browse/MESOS-4443
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> include/mesos/master/allocator.hpp e163669c9c4e4c98572968f18987704b60722a79
> src/master/allocator/mesos/allocator.hpp 581eaad376e7b2febe0b6359014617b935a677a3
> src/master/allocator/mesos/hierarchical.hpp 1f0c440565ee0f9926d168734df30fd740a53f88
> src/master/allocator/mesos/hierarchical.cpp 1a07d69016407e5aad2209586da37fecbcddb765
> src/master/master.cpp 98441a543611d4083b2495ee103f0ab5e2187e83
> src/tests/allocator.hpp 206e9ac3a83038a691f7929bdd627042b0f363b0
>
> Diff: https://reviews.apache.org/r/43091/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Alexander Rukletsov
>
>