[GitHub] [nifi-minifi-cpp] bakaid commented on issue #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of…

[GitBox <gi...@apache.org>]

bakaid commented on issue #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of…
URL: https://github.com/apache/nifi-minifi-cpp/pull/721#issuecomment-580680863
 
 
   @arpadboda Ran tests, functionality seems OK.
   I have concerns about the hardcoded value for the warning time.
   It may be perfectly valid to have onTriggers running for more than 5 seconds, especially if there are periodic commits. The general case is that it is probably not good to have an onTrigger running for more than 5 seconds, so it is a good thing to warn developers and flow creators about it, but in case it is an accepted thing, I definitely don't want a warn level log about it every second.
   I propose adding a configuration property to the effect of `nifi.scheduler.ontrigger.warning.time` with a default value of `5 sec` and using that instead of the hardcoded value.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services