You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by Sangeeta Ravindran <sa...@gmail.com> on 2016/04/27 19:20:05 UTC

Review Request 46741: Config group UI enhancements

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46741/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.

Bugs: AMBARI-16022
https://issues.apache.org/jira/browse/AMBARI-16022

Repository: ambari

Description
-------

1. The drop-down listing config-groups seems to truncate the group name when the length exceeds 18. If the config group name is longer, the full name is is not visible. The items in the drop-down list also show the partial truncated name. Having a tooltip would allow for the entire name to be displayed.
2. In Manage Config Groups, the Description field allows entry of special characters. Need to restrict characters since the description is stored in the Database.
3. Save Configuration Group dialog, the message spills outside the inner frame. Need to make the text wrap.

Fix includes adding validation for config group description field. Also includes adding tooltips to the items in the drop-down listing config-groups and the selected config-group.

Diffs
-----

ambari-web/app/controllers/main/service/manage_config_groups_controller.js e6e21bc
ambari-web/app/messages.js 8c8b9e5
ambari-web/app/models/configs/config_group.js 44e20d5
ambari-web/app/styles/application.less 8a34462
ambari-web/app/templates/common/configs/service_config.hbs 0b383d1
ambari-web/app/templates/common/configs/service_config_wizard.hbs b297d1d
ambari-web/app/templates/main/service/new_config_group.hbs 44a590d
ambari-web/app/utils/validator.js 490fec5
ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js e0ca439
ambari-web/test/models/configs/config_group_test.js b9bc56b
ambari-web/vendor/styles/bootstrap.css cd0d25a

Diff: https://reviews.apache.org/r/46741/diff/

Testing
-------

Added testcases in ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js for config group description validation and /ambari-web/test/models/configs/config_group_test.js for tooltip verification.

Ran mvn test

27619 tests complete (38 seconds)
154 tests pending

Thanks,

Sangeeta Ravindran

Re: Review Request 46741: Config group UI enhancements

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46741/#review130817
-----------------------------------------------------------




ambari-web/app/templates/common/configs/service_config.hbs (line 54)
<https://reviews.apache.org/r/46741/#comment194719>

    let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config.hbs (line 63)
<https://reviews.apache.org/r/46741/#comment194720>

    let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config_wizard.hbs (line 23)
<https://reviews.apache.org/r/46741/#comment194721>

    let's use bootsrap tooltips for this instead of simple html title



ambari-web/app/templates/common/configs/service_config_wizard.hbs (line 31)
<https://reviews.apache.org/r/46741/#comment194718>

    let's use bootsrap tooltips for this instead of simple html title


I also added note about description validation in comment in jira.

- Aleksandr Kovalenko


On Апрель 27, 2016, 5:22 п.п., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46741/
> -----------------------------------------------------------
> 
> (Updated Апрель 27, 2016, 5:22 п.п.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-16022
>     https://issues.apache.org/jira/browse/AMBARI-16022
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. The drop-down listing config-groups seems to truncate the group name when the length exceeds 18. If the config group name is longer, the full name is is not visible. The items in the drop-down list also show the partial truncated name. Having a tooltip would allow for the entire name to be displayed.
> 2. In Manage Config Groups, the Description field allows entry of special characters. Need to restrict characters since the description is stored in the Database.
> 3. Save Configuration Group dialog, the message spills outside the inner frame. Need to make the text wrap.
> 
> 
> Fix includes adding validation for config group description field. Also includes adding tooltips to the items in the drop-down listing config-groups and the selected config-group.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/manage_config_groups_controller.js e6e21bc 
>   ambari-web/app/messages.js 8c8b9e5 
>   ambari-web/app/models/configs/config_group.js 44e20d5 
>   ambari-web/app/styles/application.less 8a34462 
>   ambari-web/app/templates/common/configs/service_config.hbs 0b383d1 
>   ambari-web/app/templates/common/configs/service_config_wizard.hbs b297d1d 
>   ambari-web/app/templates/main/service/new_config_group.hbs 44a590d 
>   ambari-web/app/utils/validator.js 490fec5 
>   ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js e0ca439 
>   ambari-web/test/models/configs/config_group_test.js b9bc56b 
>   ambari-web/vendor/styles/bootstrap.css cd0d25a 
> 
> Diff: https://reviews.apache.org/r/46741/diff/
> 
> 
> Testing
> -------
> 
> Added testcases in ambari-web/test/controllers/main/service/manage_config_groups_controller_test.js for config group description validation and /ambari-web/test/models/configs/config_group_test.js for tooltip verification.
> 
> Ran mvn test in ambari-web
> 
> 27619 tests complete (38 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>