You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by YehEmily <gi...@git.apache.org> on 2017/05/30 17:02:27 UTC
[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...
GitHub user YehEmily opened a pull request:
https://github.com/apache/geode/pull/546
GEODE-2818: add alias to any command's options that involves "group", "member", "jar"
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/YehEmily/geode synonyms.rerun.rererun
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #546
----
commit 80871fe2fc68247c8f53ac3ac78aaff16adc483a
Author: YehEmily <em...@gmail.com>
Date: 2017-05-25T19:18:45Z
GEODE-2818: Edited command files and testing files to allow either 'group' or 'groups' and 'member' or 'members' and 'jar' or 'jars'
commit 3fd97485d708cdd489968e12c08153f0a39fa243
Author: YehEmily <em...@gmail.com>
Date: 2017-05-26T18:50:35Z
GEODE-2818: Edited command files and testing files to allow either 'group' or 'groups' and 'member' or 'members' and 'jar' or 'jars'
commit bcf2e7d6940cddb241418463da41a44df5e883bb
Author: YehEmily <em...@gmail.com>
Date: 2017-05-29T22:21:40Z
GEODE-2818: add alias to any command's options that involves "group", "member", "jar"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...
Posted by YehEmily <gi...@git.apache.org>.
Github user YehEmily closed the pull request at:
https://github.com/apache/geode/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] geode pull request #546: GEODE-2818: add alias to any command's options that...
Posted by jinmeiliao <gi...@git.apache.org>.
Github user jinmeiliao commented on a diff in the pull request:
https://github.com/apache/geode/pull/546#discussion_r119159305
--- Diff: geode-core/src/main/java/org/apache/geode/management/internal/cli/i18n/CliStrings.java ---
@@ -726,13 +733,13 @@
public static final String CREATE_INDEX__REGION = "region";
public static final String CREATE_INDEX__REGION__HELP =
"Name/Path of the region which corresponds to the \"from\" clause in a query.";
- public static final String CREATE_INDEX__MEMBER = "member";
+ public static final String CREATE_INDEX__MEMBER = MEMBER;
--- End diff --
I am wondering if you can delete all these other xxx_GROUP or xxx_MEMBER string declarations and change all reference of them to use the generic ones.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---