[GitHub] [dolphinscheduler] Zzih commented on a diff in pull request #12969: [Feature][Api] Refactor org.apache.dolphinscheduler.api.controller.DataAnalysisController

["Zzih (via GitHub)" <gi...@apache.org>]

Zzih commented on code in PR #12969:
URL: https://github.com/apache/dolphinscheduler/pull/12969#discussion_r1095302483


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataAnalysisService.java:
##########
@@ -41,7 +42,7 @@ public interface DataAnalysisService {
      * @param endDate     end date
      * @return task state count data
      */
-    Map<String, Object> countTaskStateByProject(User loginUser, long projectCode, String startDate, String endDate);
+    Result countTaskStateByProject(User loginUser, long projectCode, String startDate, String endDate);

Review Comment:
   But in the interface v2(path:src/main/java/org/apache/dolphinscheduler/api/controller/v2), In most cases, Result be encapsulated in service layer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org