You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Mengwei Ding <me...@gmail.com> on 2013/08/07 21:11:37 UTC
Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while retrieving
from DB if pass empty map on write
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13385/
-----------------------------------------------------------
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Bugs: SQOOP-827
https://issues.apache.org/jira/browse/SQOOP-827
Repository: sqoop-sqoop2
Description
-------
Update MMapInput for this issue. Also update all related test cases. Use MMapInput in updateConnection() now.
commit 3a08e4f9be43b3eedcd1e939423eaef39a46944f
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Aug 6 16:23:17 2013 -0700
SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write
:100644 100644 de17e2d... c41a0cb... M common/src/main/java/org/apache/sqoop/model/MMapInput.java
:100644 100644 eb877cf... 053211e... M common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
:100644 100644 eac87b8... a4199de... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 6959f2d... f9e9217... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
:100644 100644 a3d804e... 4325c5c... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
Diffs
-----
common/src/main/java/org/apache/sqoop/model/MMapInput.java de17e2d
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java eb877cf
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java 6959f2d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java a3d804e
Diff: https://reviews.apache.org/r/13385/diff/
Testing
-------
Thanks,
Mengwei Ding
Re: Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while
retrieving from DB if pass empty map on write
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13385/#review25198
-----------------------------------------------------------
Hi Mengwei,
thank you very much for working on this JIRA! I do have couple of nits:
common/src/main/java/org/apache/sqoop/model/MMapInput.java
<https://reviews.apache.org/r/13385/#comment49463>
Super nit: The second semicolon is not necessary.
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
<https://reviews.apache.org/r/13385/#comment49464>
Can we just do input1.setValue(null)?
Jarcec
- Jarek Cecho
On Aug. 7, 2013, 7:11 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13385/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2013, 7:11 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-827
> https://issues.apache.org/jira/browse/SQOOP-827
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> Update MMapInput for this issue. Also update all related test cases. Use MMapInput in updateConnection() now.
>
>
> commit 3a08e4f9be43b3eedcd1e939423eaef39a46944f
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Aug 6 16:23:17 2013 -0700
>
> SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write
>
> :100644 100644 de17e2d... c41a0cb... M common/src/main/java/org/apache/sqoop/model/MMapInput.java
> :100644 100644 eb877cf... 053211e... M common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
> :100644 100644 eac87b8... a4199de... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 6959f2d... f9e9217... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
> :100644 100644 a3d804e... 4325c5c... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MMapInput.java de17e2d
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java eb877cf
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java eac87b8
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java 6959f2d
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java a3d804e
>
> Diff: https://reviews.apache.org/r/13385/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while
retrieving from DB if pass empty map on write
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13385/#review25301
-----------------------------------------------------------
Ship it!
Ship It!
- Jarek Cecho
On Aug. 15, 2013, 5:31 p.m., Mengwei Ding wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13385/
> -----------------------------------------------------------
>
> (Updated Aug. 15, 2013, 5:31 p.m.)
>
>
> Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
>
>
> Bugs: SQOOP-827
> https://issues.apache.org/jira/browse/SQOOP-827
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> commit d354e88d56123b0a331179d41ad2df2eb5d02ba4
> Author: Mengwei Ding <me...@gmail.com>
> Date: Tue Aug 6 16:23:17 2013 -0700
>
> SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write
>
> :100644 100644 de17e2d... 37dd265... M common/src/main/java/org/apache/sqoop/model/MMapInput.java
> :100644 100644 eb877cf... 120fb07... M common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
> :100644 100644 8a5aee8... a2a0bc7... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
> :100644 100644 6959f2d... f9e9217... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
> :100644 100644 a3d804e... 4325c5c... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/sqoop/model/MMapInput.java de17e2d
> common/src/test/java/org/apache/sqoop/model/TestMMapInput.java eb877cf
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 8a5aee8
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java 6959f2d
> repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java a3d804e
>
> Diff: https://reviews.apache.org/r/13385/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mengwei Ding
>
>
Re: Review Request 13385: SQOOP-827 Sqoop2: MMapInput is null while
retrieving from DB if pass empty map on write
Posted by Mengwei Ding <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13385/
-----------------------------------------------------------
(Updated Aug. 15, 2013, 5:31 p.m.)
Review request for Sqoop, Abraham Elmahrek, Hari Shreedharan, and Jarek Cecho.
Changes
-------
Incorporate the comments. Thanks, Jarcec.
Bugs: SQOOP-827
https://issues.apache.org/jira/browse/SQOOP-827
Repository: sqoop-sqoop2
Description (updated)
-------
commit d354e88d56123b0a331179d41ad2df2eb5d02ba4
Author: Mengwei Ding <me...@gmail.com>
Date: Tue Aug 6 16:23:17 2013 -0700
SQOOP-827 Sqoop2: MMapInput is null while retrieving from DB if pass empty map on write
:100644 100644 de17e2d... 37dd265... M common/src/main/java/org/apache/sqoop/model/MMapInput.java
:100644 100644 eb877cf... 120fb07... M common/src/test/java/org/apache/sqoop/model/TestMMapInput.java
:100644 100644 8a5aee8... a2a0bc7... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 6959f2d... f9e9217... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
:100644 100644 a3d804e... 4325c5c... M repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
Diffs (updated)
-----
common/src/main/java/org/apache/sqoop/model/MMapInput.java de17e2d
common/src/test/java/org/apache/sqoop/model/TestMMapInput.java eb877cf
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java 8a5aee8
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java 6959f2d
repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java a3d804e
Diff: https://reviews.apache.org/r/13385/diff/
Testing
-------
Thanks,
Mengwei Ding