You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Mate Czagany (Jira)" <ji...@apache.org> on 2025/11/21 16:48:00 UTC
[jira] [Updated] (FLINK-38711) LicenseChecker not properly checking included artifacts
[ https://issues.apache.org/jira/browse/FLINK-38711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mate Czagany updated FLINK-38711:
---------------------------------
Description:
With the upgrade to maven-shade-plugin to 3.6.1, the following PR was also introduced: [https://github.com/apache/maven-shade-plugin/pull/233]
This is unfortunate because this log is used by LicenseChecker, and currently LicenseChecker things that absolutely no artifacts are included in any of the output JAR files, giving a false positive test.
It should be investigated if 3.6.1 can be made to work as it's required by FLINK-38391 to make the build work on JDK 25.
These are the CI logs after the maven-shade-plugin upgrade: [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69766&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=36817]
These are the CI logs from before the upgrade: [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69760&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=41781]
was:
With the upgrade to maven-shade-plugin to 3.6.1, the following PR was also introduced: [https://github.com/apache/maven-shade-plugin/pull/233]
This is unfortunate because this log is used by LicenseChecker, and currently LicenseChecker things that absolutely no artifacts are included in any of the output JAR files, giving a false positive test.
It should be investigated if 3.6.1 can be made to work as it's required by FLINK-38391 to make the build work on JDK 25.
> LicenseChecker not properly checking included artifacts
> -------------------------------------------------------
>
> Key: FLINK-38711
> URL: https://issues.apache.org/jira/browse/FLINK-38711
> Project: Flink
> Issue Type: Technical Debt
> Components: BuildSystem / Shaded
> Reporter: Mate Czagany
> Priority: Major
>
> With the upgrade to maven-shade-plugin to 3.6.1, the following PR was also introduced: [https://github.com/apache/maven-shade-plugin/pull/233]
> This is unfortunate because this log is used by LicenseChecker, and currently LicenseChecker things that absolutely no artifacts are included in any of the output JAR files, giving a false positive test.
> It should be investigated if 3.6.1 can be made to work as it's required by FLINK-38391 to make the build work on JDK 25.
>
> These are the CI logs after the maven-shade-plugin upgrade: [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69766&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=36817]
> These are the CI logs from before the upgrade: [https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=69760&view=logs&j=52b61abe-a3cc-5bde-cc35-1bbe89bb7df5&t=54421a62-0c80-5aad-3319-094ff69180bb&l=41781]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)