You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/14 17:06:42 UTC
[GitHub] [spark] tanelk opened a new pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
tanelk opened a new pull request #30040:
URL: https://github.com/apache/spark/pull/30040
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708633024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735467275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708715663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r504844237
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -40,8 +40,11 @@
private String deprecated;
private static final Set<String> validGroups =
- new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "datetime_funcs",
- "json_funcs", "map_funcs", "window_funcs"));
+ new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "binary_funcs", "bitwise_funcs",
+ "comparison_funcs", "conditional_funcs", "conversion_funcs", "csv_funcs",
+ "datetime_funcs", "generator_funcs", "grouping_funcs", "json_funcs", "logical_funcs",
+ "map_funcs", "math_funcs", "misc_funcs", "regex_funcs", "string_funcs", "struct_funcs",
+ "window_funcs", "xml_funcs"));
Review comment:
I was also considering making these values constants:
```
String GROUP_AGG_FUNCS = "agg_funcs";
String GROUP_ARRAY_FUNCS = "array_funcs";
String GROUP_BINARY_FUNCS = "binary_funcs";
...
```
Perhaps in the `ExpressionDescription` interface, but I'm not 100% sure if its better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708716531
Pretty nice, thanks a lot, @tanelk ! cc: @HyukjinKwon
> It seems, that the sql-ref-functions-builtin.html needs some redesign, for longer examples it looks quite bad:
Yea, I think so. How about adding an alias name for these examples?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r532349371
##########
File path: sql/gen-sql-functions-docs.py
##########
@@ -145,12 +148,16 @@ def _make_pretty_examples(jspark, infos):
pretty_output = ""
for info in infos:
+ if info.name == 'raise_error':
+ # TODO: how to handle this
Review comment:
Any issue here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r504842792
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -90,7 +90,8 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
> SELECT _FUNC_(NULL);
-1
""",
- since = "1.5.0")
+ since = "1.5.0",
+ group = "array_funcs")
case class Size(child: Expression, legacySizeOfNull: Boolean)
extends UnaryExpression with ExpectsInputTypes {
Review comment:
`Size` is one of the more problematic ones - should it be an array_func or a map_func or better yet both?
There are more like this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708601746
**[Test build #129745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129745/testReport)** for PR 30040 at commit [`3b686f4`](https://github.com/apache/spark/commit/3b686f4b299d758988914aa5aa57df893683179e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735455758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r505075740
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -90,7 +90,8 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
> SELECT _FUNC_(NULL);
-1
""",
- since = "1.5.0")
+ since = "1.5.0",
+ group = "array_funcs")
case class Size(child: Expression, legacySizeOfNull: Boolean)
extends UnaryExpression with ExpectsInputTypes {
Review comment:
hm, I see. Another idea: how about making a group for more general cases, e.g., `collection_funcs`? cc: @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708715663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708601746
**[Test build #129745 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129745/testReport)** for PR 30040 at commit [`3b686f4`](https://github.com/apache/spark/commit/3b686f4b299d758988914aa5aa57df893683179e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r504842792
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -90,7 +90,8 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
> SELECT _FUNC_(NULL);
-1
""",
- since = "1.5.0")
+ since = "1.5.0",
+ group = "array_funcs")
case class Size(child: Expression, legacySizeOfNull: Boolean)
extends UnaryExpression with ExpectsInputTypes {
Review comment:
`Size` is one of the more problematic ones - should it be an array_func or a map_func or better yet both?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735455758
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-709176082
Yeah .. we need to make that `sql-ref-functions-builtin.html` better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk edited a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk edited a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-728736015
> @tanelk Are you still working on this?
I haven't work on it for a while, but I'll get back to it this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-728736015
> @tanelk Are you still working on this?
I havent work on it for a while, but I'll get back to it this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708539248
@maropu , I did the first steps, but I need some extra input.
It seems, that the `sql-ref-functions-builtin.html` needs some redesign, for longer examples it looks quite bad:
The one in SQL reference looks much better (although here is no grouping):
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-728670798
@tanelk Are you still working on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708633024
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk closed pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk closed pull request #30040:
URL: https://github.com/apache/spark/pull/30040
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708632979
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34351/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735467275
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708714673
**[Test build #129745 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129745/testReport)** for PR 30040 at commit [`3b686f4`](https://github.com/apache/spark/commit/3b686f4b299d758988914aa5aa57df893683179e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735441976
**[Test build #131935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131935/testReport)** for PR 30040 at commit [`6838428`](https://github.com/apache/spark/commit/6838428b094c5832ca76387c3a66df3fab29ea23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r504841966
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -40,8 +40,11 @@
private String deprecated;
private static final Set<String> validGroups =
- new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "datetime_funcs",
- "json_funcs", "map_funcs", "window_funcs"));
+ new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "binary_funcs", "bitwise_funcs",
+ "comparison_funcs", "conditional_funcs", "conversion_funcs", "csv_funcs",
+ "datetime_funcs", "generator_funcs", "grouping_funcs", "json_funcs", "logical_funcs",
+ "map_funcs", "math_funcs", "misc_funcs", "regex_funcs", "string_funcs", "struct_funcs",
+ "window_funcs", "xml_funcs"));
Review comment:
I tried to follow the way [Presto](https://prestodb.io/docs/current/functions.html) has classified its functions, but all this is up for a change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-708623898
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34351/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] tanelk commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
tanelk commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-744678073
> @tanelk Is it difficult to keep working on this? If so, I can take this over.
Yeah, I think it would be best if you would take this over. For the most parts I would have had to consult with you anyways.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r505451042
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
##########
@@ -90,7 +90,8 @@ trait BinaryArrayExpressionWithImplicitCast extends BinaryExpression
> SELECT _FUNC_(NULL);
-1
""",
- since = "1.5.0")
+ since = "1.5.0",
+ group = "array_funcs")
case class Size(child: Expression, legacySizeOfNull: Boolean)
extends UnaryExpression with ExpectsInputTypes {
Review comment:
Seems like `size` is `collection_funcs` in `functions.scala`. I think we can just stick to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-741567256
@tanelk Is it difficult to keep working on this? If so, I can take this over.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735462965
**[Test build #131935 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131935/testReport)** for PR 30040 at commit [`6838428`](https://github.com/apache/spark/commit/6838428b094c5832ca76387c3a66df3fab29ea23).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30040:
URL: https://github.com/apache/spark/pull/30040#issuecomment-735441976
**[Test build #131935 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131935/testReport)** for PR 30040 at commit [`6838428`](https://github.com/apache/spark/commit/6838428b094c5832ca76387c3a66df3fab29ea23).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30040: [WIP][SPARK-33124][SQL][DOCS] Adds a group tag in all the expressions for built-in functions
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30040:
URL: https://github.com/apache/spark/pull/30040#discussion_r505085048
##########
File path: sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionInfo.java
##########
@@ -40,8 +40,11 @@
private String deprecated;
private static final Set<String> validGroups =
- new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "datetime_funcs",
- "json_funcs", "map_funcs", "window_funcs"));
+ new HashSet<>(Arrays.asList("agg_funcs", "array_funcs", "binary_funcs", "bitwise_funcs",
+ "comparison_funcs", "conditional_funcs", "conversion_funcs", "csv_funcs",
+ "datetime_funcs", "generator_funcs", "grouping_funcs", "json_funcs", "logical_funcs",
+ "map_funcs", "math_funcs", "misc_funcs", "regex_funcs", "string_funcs", "struct_funcs",
+ "window_funcs", "xml_funcs"));
Review comment:
hm, I see. Adding the constraints look okay because they make it easier to track these groups on IDEs, I think.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org