You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:40:26 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #4254: Name public network appropriately to avoid conflicts
Pearl1594 opened a new pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254
## Description
Multiple public networks with vlan IDs starting with the ID sequence can lead to possible conflicts and may result in associating IP to the wrong NIC.
Addresses issue: https://github.com/apache/cloudstack/issues/4247
## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671862884
@Pearl1594 or @Spaceman1984 can you investigate two intermittently failing marvin tests (the migrate vm and ssvm reboot test cases) on master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-673388427
Verified test LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671740337
<b>Trillian test result (tid-2343)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41604 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr4254-t2343-vmware-67u3.zip
Intermittent failure detected: /marvin/tests/smoke/test_ssvm.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 77 look OK, 1 have error(s)
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_11_migrate_vm | `Error` | 53.34 | test_vm_life_cycle.py
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] wido commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
wido commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-673393178
Code LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671181895
Packaging result: ✔centos7 ✔debian. JID-1688
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671171042
@Pearl1594 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671209011
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467732464
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -198,7 +198,7 @@ public static String getPublicNetworkNamePrefix(String vlanId) {
if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
return "cloud.public.untagged";
} else {
- return "cloud.public." + vlanId;
+ return "cloud.public." + vlanId + ".";
Review comment:
@rhtyd the naming convention as seen in the vcenter/mob is cloud.public.prim_vlanid.secondary_vlanid.network_rate.vswitchname so, I believe, it shouldn't cause any issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671170912
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467734042
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -198,7 +198,7 @@ public static String getPublicNetworkNamePrefix(String vlanId) {
if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
return "cloud.public.untagged";
} else {
- return "cloud.public." + vlanId;
+ return "cloud.public." + vlanId + ".";
Review comment:
Ah okay, in that case this LGTM - but please also check where the method `getPublicNetworkNamePrefix` is used if it could cause any regressions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467699511
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -198,7 +198,7 @@ public static String getPublicNetworkNamePrefix(String vlanId) {
if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
return "cloud.public.untagged";
} else {
- return "cloud.public." + vlanId;
+ return "cloud.public." + vlanId + ".";
Review comment:
@Pearl1594 would that be wrong or cause compatibility issues post upgrade? Generally port group names don't end in period (`.`) cc @PaulAngus @andrijapanicsb @borisstoyanov @vladimirpetrov?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#issuecomment-671208661
@blueorangutan test centos7 vmware-67u3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd merged pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4254: Name public network appropriately to avoid conflicts
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on a change in pull request #4254:
URL: https://github.com/apache/cloudstack/pull/4254#discussion_r467732464
##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HypervisorHostHelper.java
##########
@@ -198,7 +198,7 @@ public static String getPublicNetworkNamePrefix(String vlanId) {
if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
return "cloud.public.untagged";
} else {
- return "cloud.public." + vlanId;
+ return "cloud.public." + vlanId + ".";
Review comment:
@rhtyd the naming convention as seen in the vcenter/mob is cloud.public.<primvlanid>.<secondaryvlanid>.<network_rate>.<vswitchname> so, I believe, it shouldn't cause any issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org