You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/03 15:34:53 UTC
Review Request 40913: Made `MethodNotAllowed` response compliant to
RFC 2616.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40913/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
Bugs: MESOS-4056
https://issues.apache.org/jira/browse/MESOS-4056
Repository: mesos
Description
-------
According to RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), `MethodNotAllowed` response must include an 'Allow' header containing a list of valid methods.
This updates `MethodNotAllowed` c-tor invocations in Mesos codebase.
Diffs
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
src/slave/http.cpp eeebc79f59eb4deff12b1b8bdcd48b62d80f37fc
src/tests/executor_http_api_tests.cpp fe9df1f4d68babaf0960a3b689ffbe60704b8ad5
src/tests/scheduler_http_api_tests.cpp 4f52309ff50a5b56cf20f2c5cfddd9c10b2b75d9
Diff: https://reviews.apache.org/r/40913/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40913: Made `MethodNotAllowed` response compliant
to RFC 2616.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40913/#review109776
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 10, 2015, 12:12 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40913/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2015, 12:12 a.m.)
>
>
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
>
>
> Bugs: MESOS-4056
> https://issues.apache.org/jira/browse/MESOS-4056
>
>
> Repository: mesos
>
>
> Description
> -------
>
> According to RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), `MethodNotAllowed` response must include an 'Allow' header containing a list of valid methods.
>
> This updates `MethodNotAllowed` c-tor invocations in Mesos codebase.
>
>
> Diffs
> -----
>
> src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
> src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116
> src/tests/executor_http_api_tests.cpp 1be657c64d9ead14f1e2b41e35fd6ca04a0a56a4
> src/tests/scheduler_http_api_tests.cpp 4f52309ff50a5b56cf20f2c5cfddd9c10b2b75d9
>
> Diff: https://reviews.apache.org/r/40913/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40913: Made `MethodNotAllowed` response compliant
to RFC 2616.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40913/
-----------------------------------------------------------
(Updated Dec. 10, 2015, 12:12 a.m.)
Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van Remoortere.
Changes
-------
Rebased.
Bugs: MESOS-4056
https://issues.apache.org/jira/browse/MESOS-4056
Repository: mesos
Description
-------
According to RFC 2616 (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), `MethodNotAllowed` response must include an 'Allow' header containing a list of valid methods.
This updates `MethodNotAllowed` c-tor invocations in Mesos codebase.
Diffs (updated)
-----
src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83
src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116
src/tests/executor_http_api_tests.cpp 1be657c64d9ead14f1e2b41e35fd6ca04a0a56a4
src/tests/scheduler_http_api_tests.cpp 4f52309ff50a5b56cf20f2c5cfddd9c10b2b75d9
Diff: https://reviews.apache.org/r/40913/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov