You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/11/10 12:29:51 UTC

[GitHub] spark pull request #18972: [SPARK-21720][SQL] Fix 64KB JVM bytecode limit pr...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18972#discussion_r150222142
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/CodeGenerator.scala ---
    @@ -809,6 +809,36 @@ class CodegenContext {
       }
     
       /**
    +   * Wrap the generated code of expression, which was created from a row object in INPUT_ROW,
    +   * by a function. ev,isNull and ev.value are passed by global variables
    --- End diff --
    
    typo: `ev.isNull`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org