You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/01/14 10:53:03 UTC
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/
-----------------------------------------------------------
(Updated 一月 14, 2016, 9:53 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Summary (updated)
-----------------
Cleared the suppressed flag when deactive a framework.
Bugs: MESOS-3802
https://issues.apache.org/jira/browse/MESOS-3802
Repository: mesos
Description (updated)
-------
Cleared the suppressed flag when deactive a framework.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
Diff: https://reviews.apache.org/r/39628/diff/
Testing (updated)
-------
Ubuntu 14.04
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
Thanks,
Guangya Liu
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114471
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39628]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 14, 2016, 9:53 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 9:53 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Vinod Kone <vi...@gmail.com>.
> On Jan. 14, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1914
> > <https://reviews.apache.org/r/39628/diff/3/?file=1196600#file1196600line1914>
> >
> > I'm not sure why you needed to have framework2 and slave2 in this test at all?
> >
> > can't you just do
> >
> > // framework1 suppresses offers
> >
> > // ensure no offers are received. i.e., 'allocaiton' is pending.
> >
> > // framework1 is deactivated and reactivated.
> >
> > // ensure offer for slave1 is received.
>
> Guangya Liu wrote:
> @Vinod, does there are any helper functions which can help if there are pending allocations? I have some problem in checking `ensure no offers are received. i.e., 'allocaiton' is pending.`
>
> Did not find any helper functions so just using a complex to varify the test cases.
If you do Clock::settle(), any pending events should be acted upon. So, if we ensure `allocation` future is still pending, that should be good enough.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------
On Jan. 14, 2016, 9:53 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 9:53 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 14, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp, line 1914
> > <https://reviews.apache.org/r/39628/diff/3/?file=1196600#file1196600line1914>
> >
> > I'm not sure why you needed to have framework2 and slave2 in this test at all?
> >
> > can't you just do
> >
> > // framework1 suppresses offers
> >
> > // ensure no offers are received. i.e., 'allocaiton' is pending.
> >
> > // framework1 is deactivated and reactivated.
> >
> > // ensure offer for slave1 is received.
@Vinod, does there are any helper functions which can help if there are pending allocations? I have some problem in checking `ensure no offers are received. i.e., 'allocaiton' is pending.`
Did not find any helper functions so just using a complex to varify the test cases.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------
On 一月 14, 2016, 9:53 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated 一月 14, 2016, 9:53 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Guangya Liu <gy...@gmail.com>.
> On 一月 14, 2016, 10:55 p.m., Vinod Kone wrote:
> > src/tests/hierarchical_allocator_tests.cpp, lines 1843-1844
> > <https://reviews.apache.org/r/39628/diff/3/?file=1196600#file1196600line1843>
> >
> > How about
> >
> > // This test checks that if a framework suppresses offers, disconnects and reconnects again,
> > // it will starting receiving resource offers again.
Minor change: // it will `start` receiving resource offers again.
- Guangya
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------
On 一月 14, 2016, 9:53 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated 一月 14, 2016, 9:53 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114596
-----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 366)
<https://reviews.apache.org/r/39628/#comment175437>
s/can get resource/can be offered resources/
s/active/getting activated/
src/tests/hierarchical_allocator_tests.cpp (line 1842)
<https://reviews.apache.org/r/39628/#comment175438>
2 blank lines between outer elements.
src/tests/hierarchical_allocator_tests.cpp (lines 1843 - 1844)
<https://reviews.apache.org/r/39628/#comment175439>
How about
// This test checks that if a framework suppresses offers, disconnects and reconnects again,
// it will starting receiving resource offers again.
src/tests/hierarchical_allocator_tests.cpp (line 1891)
<https://reviews.apache.org/r/39628/#comment175446>
// Total cluster resources will become cpus=4, mem=2048.
src/tests/hierarchical_allocator_tests.cpp (line 1914)
<https://reviews.apache.org/r/39628/#comment175450>
I'm not sure why you needed to have framework2 and slave2 in this test at all?
can't you just do
// framework1 suppresses offers
// ensure no offers are received. i.e., 'allocaiton' is pending.
// framework1 is deactivated and reactivated.
// ensure offer for slave1 is received.
- Vinod Kone
On Jan. 14, 2016, 9:53 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2016, 9:53 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/#review114726
-----------------------------------------------------------
Ship it!
When committing, I will s/framework1/framework/ and s/slave1/slave/ since there is only one framework and slave in this test.
- Vinod Kone
On Jan. 15, 2016, 7:16 a.m., Guangya Liu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39628/
> -----------------------------------------------------------
>
> (Updated Jan. 15, 2016, 7:16 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Bugs: MESOS-3802
> https://issues.apache.org/jira/browse/MESOS-3802
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Cleared the suppressed flag when deactive a framework.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
> src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
>
> Diff: https://reviews.apache.org/r/39628/diff/
>
>
> Testing
> -------
>
> Ubuntu 14.04
> make
> make check
> GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
>
>
> Thanks,
>
> Guangya Liu
>
>
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/
-----------------------------------------------------------
(Updated 一月 15, 2016, 7:16 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3802
https://issues.apache.org/jira/browse/MESOS-3802
Repository: mesos
Description
-------
Cleared the suppressed flag when deactive a framework.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
Diff: https://reviews.apache.org/r/39628/diff/
Testing
-------
Ubuntu 14.04
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
Thanks,
Guangya Liu
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/
-----------------------------------------------------------
(Updated 一月 15, 2016, 7:14 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3802
https://issues.apache.org/jira/browse/MESOS-3802
Repository: mesos
Description
-------
Cleared the suppressed flag when deactive a framework.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
src/tests/hierarchical_allocator_tests.cpp.orig PRE-CREATION
Diff: https://reviews.apache.org/r/39628/diff/
Testing
-------
Ubuntu 14.04
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
Thanks,
Guangya Liu
Re: Review Request 39628: Cleared the suppressed flag when deactive a
framework.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39628/
-----------------------------------------------------------
(Updated 一月 15, 2016, 6:36 a.m.)
Review request for mesos, Ben Mahler and Vinod Kone.
Bugs: MESOS-3802
https://issues.apache.org/jira/browse/MESOS-3802
Repository: mesos
Description
-------
Cleared the suppressed flag when deactive a framework.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.cpp d541bfa3f4190865c65d35c9d1ffdb8a3f194056
src/tests/hierarchical_allocator_tests.cpp e044f832c2c16e53e663c6ced5452649bb0dcb59
Diff: https://reviews.apache.org/r/39628/diff/
Testing
-------
Ubuntu 14.04
make
make check
GLOG_v=2 ./bin/mesos-tests.sh --gtest_filter="HierarchicalAllocatorTest.DeactivateActivateFramework" --verbose
Thanks,
Guangya Liu