You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org> on 2007/01/16 11:37:27 UTC
[jira] Created: (QPID-299) Messages not being correctly requeued
when transacted session closed
Messages not being correctly requeued when transacted session closed
--------------------------------------------------------------------
Key: QPID-299
URL: https://issues.apache.org/jira/browse/QPID-299
Project: Qpid
Issue Type: Bug
Components: Java Broker
Reporter: Rob Godfrey
When using a transacted session, on closing the session (channel) the uncommitted delivered messages should be requeued and delivered to subsequent consumers. Currently this is not occuring as the requeue operation is creating a new transaction which is never committed.
The fix is to change the method close in AMQChannel by adding an explicit commit:
public void close(AMQProtocolSession session) throws AMQException
{
_txnContext.rollback();
unsubscribeAllConsumers(session);
requeue();
>> _txnContext.commit();
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (QPID-299) Messages not being correctly requeued
when transacted session closed
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey reassigned QPID-299:
--------------------------------
Assignee: Rob Godfrey
> Messages not being correctly requeued when transacted session closed
> --------------------------------------------------------------------
>
> Key: QPID-299
> URL: https://issues.apache.org/jira/browse/QPID-299
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Rob Godfrey
> Assigned To: Rob Godfrey
> Fix For: M2
>
> Attachments: qpid-299.patch
>
>
> When using a transacted session, on closing the session (channel) the uncommitted delivered messages should be requeued and delivered to subsequent consumers. Currently this is not occuring as the requeue operation is creating a new transaction which is never committed.
> The fix is to change the method close in AMQChannel by adding an explicit commit:
> public void close(AMQProtocolSession session) throws AMQException
> {
> _txnContext.rollback();
> unsubscribeAllConsumers(session);
> requeue();
> >> _txnContext.commit();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-299) Messages not being correctly requeued
when transacted session closed
Posted by "Robert Greig (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Greig resolved QPID-299.
-------------------------------
Resolution: Fixed
Fix Version/s: M2
Committed svn rev 496658
> Messages not being correctly requeued when transacted session closed
> --------------------------------------------------------------------
>
> Key: QPID-299
> URL: https://issues.apache.org/jira/browse/QPID-299
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Rob Godfrey
> Fix For: M2
>
> Attachments: qpid-299.patch
>
>
> When using a transacted session, on closing the session (channel) the uncommitted delivered messages should be requeued and delivered to subsequent consumers. Currently this is not occuring as the requeue operation is creating a new transaction which is never committed.
> The fix is to change the method close in AMQChannel by adding an explicit commit:
> public void close(AMQProtocolSession session) throws AMQException
> {
> _txnContext.rollback();
> unsubscribeAllConsumers(session);
> requeue();
> >> _txnContext.commit();
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (QPID-299) Messages not being correctly requeued
when transacted session closed
Posted by "Rob Godfrey (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Rob Godfrey updated QPID-299:
-----------------------------
Attachment: qpid-299.patch
> Messages not being correctly requeued when transacted session closed
> --------------------------------------------------------------------
>
> Key: QPID-299
> URL: https://issues.apache.org/jira/browse/QPID-299
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Reporter: Rob Godfrey
> Attachments: qpid-299.patch
>
>
> When using a transacted session, on closing the session (channel) the uncommitted delivered messages should be requeued and delivered to subsequent consumers. Currently this is not occuring as the requeue operation is creating a new transaction which is never committed.
> The fix is to change the method close in AMQChannel by adding an explicit commit:
> public void close(AMQProtocolSession session) throws AMQException
> {
> _txnContext.rollback();
> unsubscribeAllConsumers(session);
> requeue();
> >> _txnContext.commit();
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira