You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/20 04:11:11 UTC
[GitHub] [flink-kubernetes-operator] wangyang0918 opened a new pull request, #229: [hotfix] Change version of documentation in update_branch_version.sh
wangyang0918 opened a new pull request, #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229
We also need to change version of documentation in `update_branch_version.sh`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on code in PR #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877779395
##########
tools/releasing/update_branch_version.sh:
##########
@@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" Do
# change Helm chart version info
perl -pi -e "s#^version: .*#version: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
perl -pi -e "s#^appVersion: .*#appVersion: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
-
+#change version of documentation
+cd docs
+perl -pi -e "s#^ Version = .*# Version = \"${NEW_VERSION}\"#" config.toml
+perl -pi -e "s#^ VersionTitle = .*# VersionTitle = \"${NEW_VERSION}\"#" config.toml
+cd ..
Review Comment:
I do not mean to update the release branch, but the main branch. It is still `1.0-SNAPSHOT`, not `1.1-SNAPSHOT`.
https://github.com/apache/flink-kubernetes-operator/blob/main/docs/config.toml#L37
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora merged pull request #229: [hotfix] Change version of documentation in update_branch_version.sh
Posted by GitBox <gi...@apache.org>.
gyfora merged PR #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877749413
##########
tools/releasing/update_branch_version.sh:
##########
@@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" Do
# change Helm chart version info
perl -pi -e "s#^version: .*#version: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
perl -pi -e "s#^appVersion: .*#appVersion: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
-
+#change version of documentation
+cd docs
+perl -pi -e "s#^ Version = .*# Version = \"${NEW_VERSION}\"#" config.toml
+perl -pi -e "s#^ VersionTitle = .*# VersionTitle = \"${NEW_VERSION}\"#" config.toml
+cd ..
Review Comment:
On a second thought, it wouldnt really hurt (it's currently also out of date on the main branch). For rc branches it should not change anything if the release branch is already updated correctly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #229: [hotfix] Change version of documentation in update_branch_version.sh
Posted by GitBox <gi...@apache.org>.
gyfora commented on code in PR #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229#discussion_r877748770
##########
tools/releasing/update_branch_version.sh:
##########
@@ -64,7 +64,11 @@ perl -pi -e "s#^ENV OPERATOR_VERSION=.*#ENV OPERATOR_VERSION=${NEW_VERSION}#" Do
# change Helm chart version info
perl -pi -e "s#^version: .*#version: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
perl -pi -e "s#^appVersion: .*#appVersion: ${NEW_VERSION}#" helm/flink-kubernetes-operator/Chart.yaml
-
+#change version of documentation
+cd docs
+perl -pi -e "s#^ Version = .*# Version = \"${NEW_VERSION}\"#" config.toml
+perl -pi -e "s#^ VersionTitle = .*# VersionTitle = \"${NEW_VERSION}\"#" config.toml
+cd ..
Review Comment:
I don't think we should do this here. The docs are built from the release branch (which otherwise has the snapshot version). I think we need to update the config manually when cutting the release branch like you did
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #229: [hotfix] Change version of documentation in update_branch_version.sh
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on PR #229:
URL: https://github.com/apache/flink-kubernetes-operator/pull/229#issuecomment-1132438195
cc @gyfora
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org