[GitHub] [netbeans] mbien commented on a diff in pull request #5852: prepare NB 19 release cycle for JDK 11.

["mbien (via GitHub)" <gi...@apache.org>]

mbien commented on code in PR #5852:
URL: https://github.com/apache/netbeans/pull/5852#discussion_r1179434962


##########
.github/workflows/main.yml:
##########
@@ -2391,7 +2391,7 @@ jobs:
     timeout-minutes: 60
     strategy:
       matrix:
-        java: [ '8' ]
+        java: [ '11' ]

Review Comment:
   @dbalek @sdedic this would move the NBVSCode ext and the LSP job to JDK 11 since those jobs load all other modules. If the VSCode Ext has different requirements we would have to change the test setup there.
   
   But from past conversations I believe to remember that JDK 11 was no problem there, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists