You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2017/11/16 15:50:10 UTC

[GitHub] mrutkows opened a new issue #648: Examine use of NewYAMLFileFormat error

mrutkows opened a new issue #648: Examine use of NewYAMLFileFormat error
URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/648
 
 
   See comments why this issue was created in PR https://github.com/apache/incubator-openwhisk-wskdeploy/pull/632
   
   using grep, we should look at the folloiwing usages of this error, and if they are simply creating a new error from a better/lower-level error, they should be removed.
   ```
   $ grep -r NewYAMLFileFormatError . --include=*.go
   ./deployers/deploymentreader.go:					return utils.NewYAMLFileFormatError(utils.UNKNOWN, err)
   ./deployers/deploymentreader.go:						return utils.NewYAMLFileFormatError(utils.UNKNOWN, err)
   ./deployers/deploymentreader.go:						return utils.NewYAMLFileFormatError(utils.UNKNOWN, err)
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifest.Filepath, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:		return utils.NewYAMLFileFormatError(manifestName, err.Error())
   ./deployers/manifestreader.go:					return utils.NewYAMLFileFormatError(depName, err.Error())
   ./deployers/servicedeployer.go:			return utils.NewYAMLFileFormatError(utils.UNKNOWN, "Project name in manifest file is mandatory for managed deployments")
   ./deployers/servicedeployer.go:			return utils.NewYAMLFileFormatError(utils.UNKNOWN, err.Error())
   ./deployers/servicedeployer.go:				return utils.NewYAMLFileFormatError(manifest.Filepath, errorString)
   ./deployers/servicedeployer.go:				return deployer.Deployment, utils.NewYAMLFileFormatError(manifest.Filepath, errorString)
   ./parsers/manifest_parser.go:		return utils.NewYAMLFileFormatError(filename, err.Error())
   ./utils/wskdeployerror.go:func NewYAMLFileFormatError(fpath string, errorMessage string) *YAMLFileFormatError {
   ./utils/wskdeployerror_test.go:	err6 := NewYAMLFileFormatError(TEST_INVALID_YAML_MANIFEST_FILE, TEST_DEFAULT_ERROR_MESSAGE)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services