You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 15:15:23 UTC
[GitHub] [apisix-dashboard] nic-chen opened a new issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
nic-chen opened a new issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940
# Bug report
## How to Reproduce
1. use dashboard to create a route without filling in `remote address`
2. wait a few minutes, will find some error log like
```
2020/12/01 22:44:48 [error] 34404#36781528: *230358 [lua] config_etcd.lua:509: failed to fetch data from etcd: failed to check item data of [/apisix/routes] err:property "remote_addrs" validation failed: failed to validate item 1: object matches none of the requireds, etcd key: /apisix/routes, context: ngx.timer
2020/12/01 22:44:48 [error] 34408#36781532: *230380 [lua] config_etcd.lua:509: failed to fetch data from etcd: failed to check item data of [/apisix/routes] err:property "remote_addrs" validation failed: failed to validate item 1: object matches none of the requireds, etcd key: /apisix/routes, context: ngx.timer
2020/12/01 22:44:48 [error] 34409#36781533: *230352 [lua] config_etcd.lua:509: failed to fetch data from etcd: failed to check item data of [/apisix/routes] err:property "remote_addrs" validation failed: failed to validate item 1: object matches none of the requireds, etcd key: /apisix/routes, context: ngx.timer
```
3. the route doesn't work
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736950730
@LiteSun
"not pass the remote_addrs field" should be better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736626276
Server API should never trust input
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
LiteSun commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736946517
I noticed that remote_addrs is not required in [apisix](https://github.com/apache/apisix/blob/master/doc/admin-api.md#route ). When the user does not enter remote_addrs, should the client pass [] or not pass the remote_addrs field? @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736950789
> I noticed that remote_addrs is not required in [apisix](https://github.com/apache/apisix/blob/master/doc/admin-api.md#route). When the user does not enter remote_addrs, should the client pass [] or not pass the remote_addrs field? @nic-chen
https://github.com/apache/apisix-dashboard/issues/856#issuecomment-736624035 I have replied this question before.
`When the user not filled, should no field remote_addrs. this should be a bug of the frontend`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736633083
> sureļ¼backend need to fix it too
APISIX has fixed this bug: https://github.com/apache/apisix/pull/2907/files
need to sync the JSON schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736933311
oh I noticed this comment, API should never trust any data from client.
> Server API should never trust input
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736932980
related issue https://github.com/apache/apisix-dashboard/issues/856#issuecomment-736578374
Just to make sure, will manager-api check the input from the client? (no matter using API or frontend), the manager-api must not trust any data from client.
cc @nic-chen @membphis @ShiningRush
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736629629
sureļ¼backend need to fix it too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940#issuecomment-736624666
@juzhiyuan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #940: bug: when user not fill in `remote address` , `remote_addrs` should be [], but not [""]
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #940:
URL: https://github.com/apache/apisix-dashboard/issues/940
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org